Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing differences between Starlette and Uvicorn #1249

Closed
Gascognya opened this issue Jul 22, 2021 · 3 comments
Closed

Typing differences between Starlette and Uvicorn #1249

Gascognya opened this issue Jul 22, 2021 · 3 comments
Labels
typing Type annotations or mypy issues

Comments

@Gascognya
Copy link

Gascognya commented Jul 22, 2021

uvicorn.run(app) need typing: 'ASGIApplication'
(the asgiref package)

it's difference from typing of Starlette.__call__(self, scope: Scope, receive: Receive, send: Send) -> None

SO, IDE check and display a waring, about app
uvicorn.run(app, host="127.0.0.1", port=8080)

@JayH5 JayH5 added the typing Type annotations or mypy issues label Aug 16, 2021
@JayH5
Copy link
Member

JayH5 commented Aug 16, 2021

This issue is because we haven't solved #1217.

@Kludex
Copy link
Member

Kludex commented Sep 3, 2021

If someone is eager, feel free to take over my PR. I don't feel like working on it any time soon.

@Kludex
Copy link
Member

Kludex commented Nov 27, 2021

Even if the story is different, this is fundamentally the same as #1217.

For that reason, and housekeeping, I'm closing this issue.

Thanks for reporting it @Gascognya ! :)

@Kludex Kludex closed this as completed Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typing Type annotations or mypy issues
Projects
None yet
Development

No branches or pull requests

3 participants