You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The bug is reproducible against the latest release or master.
There are no similar issues or pull requests to fix it yet.
Describe the bug
As per encode/starlette#1336, scope["root_path"] is never supposed to be joined to scope["path"], as the latter is supposed to be already prefixed with the former. Luckily uvicorn is never doing this except in logging. It is logging incorrect paths (according to ASGI spec) in the following places:
Checklist
master
.Describe the bug
As per encode/starlette#1336,
scope["root_path"]
is never supposed to be joined toscope["path"]
, as the latter is supposed to be already prefixed with the former. Luckily uvicorn is never doing this except in logging. It is logging incorrect paths (according to ASGI spec) in the following places:https://github.com/encode/uvicorn/blob/master/uvicorn/protocols/websockets/wsproto_impl.py#L256
https://github.com/encode/uvicorn/blob/master/uvicorn/protocols/websockets/wsproto_impl.py#L272
https://github.com/encode/uvicorn/blob/master/uvicorn/protocols/websockets/websockets_impl.py#L230
https://github.com/encode/uvicorn/blob/master/uvicorn/protocols/websockets/websockets_impl.py#L240
https://github.com/encode/uvicorn/blob/master/uvicorn/protocols/utils.py#L50
Steps to reproduce the bug
No response
Expected behavior
No response
Actual behavior
No response
Debugging material
No response
Environment
Running uvicorn 0.16.0 with CPython 3.8.10 on Darwin
Additional context
No response
The text was updated successfully, but these errors were encountered: