Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for sendfile #35

Closed
tomchristie opened this issue Jun 27, 2017 · 8 comments
Closed

Support for sendfile #35

tomchristie opened this issue Jun 27, 2017 · 8 comments

Comments

@tomchristie
Copy link
Member

tomchristie commented Jun 27, 2017

Support sendfile usage.

Would require an ASGI extension.

@tomchristie tomchristie changed the title sendfile Support for sendfile. Jun 29, 2018
@tomchristie tomchristie changed the title Support for sendfile. Support for sendfile Jun 29, 2018
@tomchristie tomchristie added this to the Version 1.1 milestone Jul 25, 2018
@tomchristie tomchristie modified the milestones: Version 1.1, Version 1.2 Jul 25, 2018
@est
Copy link

est commented Jun 29, 2020

Are there any estimate when will V1.2 milestone come out?

@abersheeran
Copy link
Member

https://asgi.readthedocs.io/en/latest/extensions.html#zero-copy-send The relevant ASGI documentation has been completed.

@Kludex
Copy link
Member

Kludex commented Dec 5, 2022

Given @tomchristie 's comment on the PR that implemented sendfile support, and the fact that there were not many interested in this feature over the years, I'll be closing this issue.

If people are interested, we can always reevaluate this decision.

@Kludex Kludex closed this as not planned Won't fix, can't repro, duplicate, stale Dec 5, 2022
@Archmonger
Copy link

@Kludex If/when this feature gets developed I will merge zerocopysend support into WhiteNoise.

Adding support within WhiteNoise would be fairly quick, but I don't know if I will have time on the immediate horizon to PR this into uvicorn. I have too many prior OSS commitments so it would most likely be a year or two before I could get to this.

@septatrix
Copy link

I would also like to express my interest in this feature as my server does quite a bit of file-io which I would like to offload

@Archmonger
Copy link

Related:

@tomchristie
Copy link
Member Author

@Archmonger You could start by doing a proof of concept for...

  • A zero-copy-send implementation that doesn't support offset/count/more_body.
  • Show a new clean pull request for that.
  • Demo the performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants