Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support gatherings with > 19 participants #1658

Closed
brenzi opened this issue Mar 6, 2024 · 4 comments · Fixed by #1663
Closed

support gatherings with > 19 participants #1658

brenzi opened this issue Mar 6, 2024 · 4 comments · Fixed by #1663

Comments

@brenzi
Copy link
Member

brenzi commented Mar 6, 2024

As we are increasing the target gathering size to 15, it can happen that gatherings get assigned with 19 or even more people.

19 seems supported: https://github.com/encointer/encointer-wallet-flutter/tree/master/app/assets/avatars

but this is very tight. See probabilities here:
encointer/pallets#372

@clangenb
Copy link
Member

clangenb commented Mar 7, 2024

@Eldar2021 Do you remember, where you got the avatars from? :)

@Eldar2021
Copy link
Member

I don't remember much, but I'll try to find it on the internet.

@Eldar2021
Copy link
Member

I'm glad I found it easy :)

https://www.svgrepo.com/svg/191396/lion

In this case I suggest to place avatars in the encointer-feed repository and use them with SvgPicture.network in the app. Why?

  1. We are not releasing a new version just for a small avatar.
  2. The size of our .apk/.ipa file will decrease slightly.

@clangenb
Copy link
Member

Thanks a lot @Eldar2021! Out of laziness, I did not change the process of getting the avatar, although I do think that the apk size matters. On the other hand, we want to allow offline meetups, which is why we should have the avatars inside the apk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants