Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make reputation commitment an OptionQuery #356

Open
brenzi opened this issue Sep 29, 2023 · 0 comments
Open

make reputation commitment an OptionQuery #356

brenzi opened this issue Sep 29, 2023 · 0 comments

Comments

@brenzi
Copy link
Member

brenzi commented Sep 29, 2023

Option<H256>,
ValueQuery,

It is bad practise to combine an Option<_> with Value Query, because that makes it less intuitive to evaluate

  • if the storage exists (need to check if key exists, querying storage will default to None in two different cases: the storage has never been written, or None has actually been written
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant