Skip to content

Incorrectly paired section match % for multiple .text sections #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LagoLunatic opened this issue Oct 11, 2024 · 1 comment
Closed

Incorrectly paired section match % for multiple .text sections #120

LagoLunatic opened this issue Oct 11, 2024 · 1 comment

Comments

@LagoLunatic
Copy link
Contributor

image

On the right side, for units that have multiple .text sections, the individual section match % is incorrect for the first .text section (61% is for the last .text section, not the first). For all of the other .text sections, no match %s are shown at all.

This isn't a big deal because the left side knows how to pair its sections with the right side, and it shows all of the correct percentages (e.g. 29% for the first one, 100% for the second, 61% for the last), so it's possible to just ignore the wrong section % on the right side.

Version: 2.3.1, but also at least as far back as 2.0.0-beta.5.

@LagoLunatic
Copy link
Contributor Author

By the way, this bug also seems to affect the json reports generated by objdiff-cli. Every text section gets paired up with the first one, which results in dozens of wrong diffs like these bloating the reports and making the "sections" part of the report pretty hard to read:

        {
          "name": ".text",
          "from": {
            "fuzzy_match_percent": 100.0,
            "size": "2124"
          },
          "to": {
            "fuzzy_match_percent": 30.282476,
            "size": "156048"
          },
          "metadata": {
            "virtual_address": "2148544140"
          }
        },

(Doesn't affect the "functions" part of the report.)

Version: objdiff-cli 3.0.0-beta.4 (probably others too)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant