Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host code in start compartment can corrupt SES between initialization and lockdown #818

Closed
kriskowal opened this issue Jul 8, 2021 · 0 comments · Fixed by #827
Closed
Assignees

Comments

@kriskowal
Copy link
Member

kriskowal commented Jul 8, 2021

Although SES is vulnerable to all code that runs before it, and possibly some vetted shims that run after it initializes but before lockdown, SES attempts to protect itself from poisoned intrinsics by capturing original constructors, prototypes, and uncurried methods in commons.js. We should have a lint rule specifically for the SES repository to encourage use of the exports of commons.js over reaching for these possibly poisoned globals.

One possible solution is to add lint rules that disallow polymorphic method calls / dynamic dispatch vigorously, then make more use of uncurryThis.

@kriskowal kriskowal linked a pull request Aug 13, 2021 that will close this issue
@kriskowal kriskowal changed the title Add lint rules to protect against poisoned intrinsics in SES Host code in start compartment can corrupt SES between initialization and lockdown Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants