Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

harden 262-style tests: order, atomicity #909

Open
4 tasks
dckc opened this issue Sep 28, 2021 · 1 comment
Open
4 tasks

harden 262-style tests: order, atomicity #909

dckc opened this issue Sep 28, 2021 · 1 comment
Assignees
@kriskowal @dckc @erights
Labels
kriskowal-review-2024-01 Issues that kriskowal wants to bring to the attention of the team for review as of January, 2024
Milestone
JS Compartments t...

Comments

@dckc
Copy link
Contributor

dckc commented Sep 28, 2021

What is the Problem Being Solved?

XS has a draft of native harden() but it differs from the SES shim in the 3 ways enumerated below

Description of the Design

per make-hardener.js 14e451c Jul 7

Security Considerations

The usual security benefits of fail-stop deterministic execution apply.

Test Plan

262 tests:

  • breadth-first vs. depth-first traversal order
  • order of protype vs. properties
  • atomicity - don't mark anything hardened if hardening fails in the middle of traversal

plus:

  • make sure at least these 262 tests run in ci for the SES shim

cc @kriskowal @mhofman @phoddie
@dckc dckc added this to the JS Compartments to Stage 2 milestone Sep 28, 2021
@dckc dckc assigned dckc and erights Sep 28, 2021
@kriskowal kriskowal added the kriskowal-review-2024-01 Issues that kriskowal wants to bring to the attention of the team for review as of January, 2024 label Jan 10, 2024
@kriskowal kriskowal self-assigned this Jan 10, 2024
@kriskowal
Copy link
Member

kriskowal commented Jan 10, 2024 •
edited
Loading

With #1847 we have a place to stand to do this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kriskowal kriskowal

@dckc dckc

@erights erights

Labels
kriskowal-review-2024-01 Issues that kriskowal wants to bring to the attention of the team for review as of January, 2024
Projects
None yet
Milestone
JS Compartments to Stage 2
Development

No branches or pull requests
3 participants
@kriskowal @dckc @erights