Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync spec and XS interpretation of Date(), Date.now(), and Math.random() #934

Open
kriskowal opened this issue Nov 10, 2021 · 0 comments
Open

Sync spec and XS interpretation of Date(), Date.now(), and Math.random() #934

kriskowal opened this issue Nov 10, 2021 · 0 comments
Assignees
@kriskowal
Labels
good first issue Good for newcomers kriskowal-just-do-it-2024-01 Tasks that kriskowal can close out quickly to clear weeds kriskowal-review-2024-01 Issues that kriskowal wants to bring to the attention of the team for review as of January, 2024

Comments

@kriskowal
Copy link
Member

As discussed with Moddable, in XS, all of these will throw: agoric-labs/xsnap-pub@9469c42#diff-2bef77289c9089a24d38a9e7138870c810bcc4665c96ab33dc20a615fea74111R16-R17

We currently return NaN dates and random is merely deleted (unless memory fails me).
@kriskowal kriskowal self-assigned this Nov 10, 2021
@kriskowal kriskowal mentioned this issue Nov 10, 2021
Merged
This was referenced Jan 20, 2022
Open
Open
@kriskowal kriskowal mentioned this issue Feb 2, 2022
Closed
@kriskowal kriskowal added kriskowal-review-2024-01 Issues that kriskowal wants to bring to the attention of the team for review as of January, 2024 good first issue Good for newcomers kriskowal-just-do-it-2024-01 Tasks that kriskowal can close out quickly to clear weeds labels Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kriskowal kriskowal

Labels
good first issue Good for newcomers kriskowal-just-do-it-2024-01 Tasks that kriskowal can close out quickly to clear weeds kriskowal-review-2024-01 Issues that kriskowal wants to bring to the attention of the team for review as of January, 2024
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kriskowal