Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(print): subtract indent in print statement #332

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Conversation

engeir
Copy link
Owner

@engeir engeir commented Mar 16, 2023

The variable list printed when using the short option has to get a width that is its indent level less than the full width.

The variable list printed when using the `short` option has to get a
width that is its indent level less than the full width.
@engeir engeir added bug Something isn't working python Pull requests that update Python code labels Mar 16, 2023
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Mar 16, 2023

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.81%.

Quality metrics Before After Change
Complexity 32.00 😞 31.00 😞 -1.00 👍
Method Length 239.50 ⛔ 232.50 ⛔ -7.00 👍
Working memory 0.00 ⭐ 0.00 ⭐ 0.00
Quality 13.91% 14.72% 0.81% 👍
Other metrics Before After Change
Lines 161 155 -6
Changed files Quality Before Quality After Quality Change
src/ncdump_rich/ncdump.py 13.91% ⛔ 14.72% ⛔ 0.81% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
src/ncdump_rich/ncdump.py ncdump 31 😞 447 ⛔ 14.72% ⛔ Refactor to reduce nesting. Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@engeir engeir merged commit b5ad47d into main Mar 16, 2023
@engeir engeir deleted the fix-lineshift branch March 16, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant