Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(system): change to use Rye over Poetry #388

Merged
merged 10 commits into from
Feb 27, 2024
Merged

build(system): change to use Rye over Poetry #388

merged 10 commits into from
Feb 27, 2024

Conversation

engeir
Copy link
Owner

@engeir engeir commented Feb 27, 2024

No description provided.

@engeir engeir added build Build System and Dependencies ci Continuous Integration labels Feb 27, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Refactoring

PR Summary: This pull request encompasses a significant shift in the project's dependency management and build system, transitioning from Poetry to Rye. It updates various GitHub Actions workflows, including tests, release, and latest screengrab configurations, to use Rye for dependency management and package installation. Additionally, it updates the Python version used in these workflows to 3.12 and modifies the noxfile.py to reflect these changes. The PR also includes adjustments to the pre-commit configuration to utilize Rye for running hooks.

Decision: Comment

📝 Type: 'Refactoring' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
  • Unsupported files: the diff contains files that Sourcery does not currently support during reviews.

General suggestions:

  • Ensure that all contributors are aware of the transition from Poetry to Rye, as this change requires updates to local development environments.
  • Consider adding documentation or a migration guide to help contributors transition to using Rye, including any necessary commands or environment setup.
  • Verify that all dependencies managed by Poetry are compatible with Rye and that there are no issues with dependency resolution or package installation.
  • Test the updated workflows extensively to ensure that the CI/CD pipeline functions as expected with the new tooling.
  • Review the choice of Rye over other tools to ensure it aligns with the project's long-term goals and addresses any limitations encountered with Poetry.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@engeir engeir merged commit a5b19dd into main Feb 27, 2024
@engeir engeir deleted the use-rye branch February 27, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build System and Dependencies ci Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant