Skip to content

Commit 77579ba

Browse files
authored
[two_dimensional_scrollables] Post 3.16 stable tech debt clean up (flutter#5671)
Fixes flutter#136933 Fixes flutter#132782 This cleans up some TODOs in the TableView and its tests after the stable release - removes an assertion on the builder delegate bounds now that the super class handles the assertions - refactors all of the golden file tests using PaintPattern, removing all of the golden files and enabling web testing
1 parent 1151191 commit 77579ba

File tree

7 files changed

+240
-104
lines changed

7 files changed

+240
-104
lines changed

packages/two_dimensional_scrollables/dart_test.yaml

Lines changed: 0 additions & 3 deletions
This file was deleted.

packages/two_dimensional_scrollables/lib/src/table_view/table_delegate.dart

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -150,8 +150,6 @@ class TableCellBuilderDelegate extends TwoDimensionalChildBuilderDelegate
150150
int get columnCount => maxXIndex! + 1;
151151
set columnCount(int value) {
152152
assert(pinnedColumnCount <= value);
153-
// TODO(Piinks): remove once this assertion is added in the super class
154-
assert(value >= -1);
155153
maxXIndex = value - 1;
156154
}
157155

@@ -180,8 +178,6 @@ class TableCellBuilderDelegate extends TwoDimensionalChildBuilderDelegate
180178
int get rowCount => maxYIndex! + 1;
181179
set rowCount(int value) {
182180
assert(pinnedRowCount <= value);
183-
// TODO(Piinks): remove once this assertion is added in the super class
184-
assert(value >= -1);
185181
maxYIndex = value - 1;
186182
}
187183

Binary file not shown.
Binary file not shown.

0 commit comments

Comments
 (0)