Skip to content

Commit 1f1eec0

Browse files
authored
Make leak tracking bots blocking. (#157866)
See http://flutter.dev/go/leak-tracker-make-bots-blocking
1 parent c55f604 commit 1f1eec0

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

.ci.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5625,10 +5625,8 @@ targets:
56255625

56265626
- name: Windows framework_tests_libraries_leak_tracking
56275627
recipe: flutter/flutter_drone
5628-
bringup: true # New target: https://github.com/flutter/flutter/issues/140414
56295628
timeout: 120
56305629
properties:
5631-
ignore_flakiness: "true"
56325630
test_timeout_secs: "3600" # 1 hour
56335631
dependencies: >-
56345632
[
@@ -5712,10 +5710,8 @@ targets:
57125710

57135711
- name: Windows framework_tests_widgets_leak_tracking
57145712
recipe: flutter/flutter_drone
5715-
bringup: true # New target: https://github.com/flutter/flutter/issues/140414
57165713
timeout: 120
57175714
properties:
5718-
ignore_flakiness: "true"
57195715
test_timeout_secs: "3600" # 1 hour
57205716
dependencies: >-
57215717
[

docs/contributing/testing/Leak-tracking.md

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,19 @@
1-
# Leak tracking in Flutter framework
1+
# Leak tracking in Flutter Framework
22

3-
Flutter Framework widget tests use [leak_tracker](https://github.com/dart-lang/leak_tracker/blob/main/doc/leak_tracking/
4-
OVERVIEW.md) to detect leaks from objects that have not been disposed.
3+
## TL;DR;
54

6-
This page contains Flutter Framework related information.
5+
To enable leak tracking locally pass `--dart-define LEAK_TRACKING=true` to `flutter test`.
76

87
See leak_tracker documentation for
98
[general leak troubleshooting](https://github.com/dart-lang/leak_tracker/blob/main/doc/leak_tracking/TROUBLESHOOT.md).
109

10+
This page contains Flutter Framework specific information.
11+
12+
## Overview
13+
14+
Flutter Framework widget tests use [leak_tracker](https://github.com/dart-lang/leak_tracker/blob/main/doc/leak_tracking/
15+
OVERVIEW.md) to detect leaks from objects that have not been disposed.
16+
1117
Test failures cause by leaks look like this:
1218

1319
```
@@ -32,8 +38,8 @@ disposables are disposed.
3238
If a tests is opted out, the reasons should be clearly explained
3339
in the comments.
3440

35-
It is ok to opt out a test when a test
36-
throws an exception and the code did not finalize properly.
41+
It is ok to opt out a test when the test
42+
throws an exception and thus the code did not finalize properly.
3743

3844
While some exceptions should be finalized properly
3945
and should not result in leaking objects,
@@ -59,5 +65,3 @@ For local testing, or for test shards configuration, to enable leak tracking for
5965
`--dart-define LEAK_TRACKING=true` to `flutter test`.
6066

6167
You can see the bot's status on the [Flutter build dashboard](https://flutter-dashboard.appspot.com/#/build).
62-
The bots are not blocking yet.
63-
See [a proposal to convert them to be blocking](http://flutter.dev/go/leak-tracker-make-bots-blocking).

0 commit comments

Comments
 (0)