Skip to content

Commit 355a460

Browse files
authored
Fix misunderstanding of properties vs. drone_dimensions in Linux_build_tests (#152796)
In "build tests", the `properties` of the build specify the configuration of the coordinator, and the `drone_dimensions` specify the configuration of the devicelab bot. This PR should therefore fix the infra errors on the `Linux_build_test` tests caused by my last PR at flutter/flutter#152756. (Unfortunately, a simple revert won't work since the MotoG4s have already been removed from the Linux hosts.)
1 parent d6515af commit 355a460

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

.ci.yaml

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,9 @@ platform_properties:
6666
{"dependency": "open_jdk", "version": "version:17"},
6767
{"dependency": "curl", "version": "version:7.64.0"}
6868
]
69-
os: Linux
70-
device_type: "mokey"
69+
os: Ubuntu
70+
cores: "8"
71+
device_type: none
7172
linux_android:
7273
properties:
7374
dependencies: >-
@@ -2853,6 +2854,8 @@ targets:
28532854
["devicelab", "android", "linux", "mokey"]
28542855
task_name: flutter_gallery__transition_perf
28552856
artifact: gallery__transition_perf
2857+
drone_dimensions: >
2858+
["device_os=N","os=Linux", "device_type=mokey"]
28562859
28572860
- name: Linux_build_test flutter_gallery__transition_perf_e2e
28582861
recipe: devicelab/devicelab_drone_build_test
@@ -2864,6 +2867,8 @@ targets:
28642867
["devicelab", "android", "linux", "mokey"]
28652868
task_name: flutter_gallery__transition_perf_e2e
28662869
artifact: gallery__transition_perf_e2e
2870+
drone_dimensions: >
2871+
["device_os=N","os=Linux", "device_type=mokey"]
28672872
28682873
- name: Linux_build_test flutter_gallery__transition_perf_hybrid
28692874
recipe: devicelab/devicelab_drone_build_test
@@ -2875,6 +2880,8 @@ targets:
28752880
["devicelab", "android", "linux", "mokey"]
28762881
task_name: flutter_gallery__transition_perf_hybrid
28772882
artifact: gallery__transition_perf_hybrid
2883+
drone_dimensions: >
2884+
["device_os=N","os=Linux", "device_type=mokey"]
28782885
28792886
# linux mokey benchmark
28802887
- name: Linux_mokey flutter_gallery__transition_perf_with_semantics

0 commit comments

Comments
 (0)