Skip to content

Commit 47403e3

Browse files
authored
Migrate test_compiler_test.dart to explicit-package-dependencies. (#160265)
Work towards flutter/flutter#160257.
1 parent 1e2322c commit 47403e3

File tree

1 file changed

+22
-0
lines changed

1 file changed

+22
-0
lines changed

packages/flutter_tools/test/general.shard/test/test_compiler_test.dart

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ import 'package:flutter_tools/src/base/logger.dart';
99
import 'package:flutter_tools/src/base/platform.dart';
1010
import 'package:flutter_tools/src/build_info.dart';
1111
import 'package:flutter_tools/src/compile.dart';
12+
import 'package:flutter_tools/src/dart/pub.dart';
13+
import 'package:flutter_tools/src/features.dart';
1214
import 'package:flutter_tools/src/project.dart';
1315
import 'package:flutter_tools/src/test/test_compiler.dart';
1416
import 'package:flutter_tools/src/test/test_time_recorder.dart';
@@ -17,6 +19,8 @@ import 'package:test/fake.dart';
1719

1820
import '../../src/common.dart';
1921
import '../../src/context.dart';
22+
import '../../src/fake_pub_deps.dart';
23+
import '../../src/fakes.dart';
2024
import '../../src/logging_logger.dart';
2125

2226
final Platform linuxPlatform = FakePlatform(
@@ -38,6 +42,12 @@ void main() {
3842
late FileSystem fileSystem;
3943
late LoggingLogger logger;
4044

45+
// TODO(matanlurey): Remove after `explicit-package-dependencies` is enabled by default.
46+
// See https://github.com/flutter/flutter/issues/160257 for details.
47+
FeatureFlags enableExplicitPackageDependencies() {
48+
return TestFeatureFlags(isExplicitPackageDependenciesEnabled: true);
49+
}
50+
4151
setUp(() {
4252
fileSystem = MemoryFileSystem.test();
4353
fileSystem.file('pubspec.yaml').createSync();
@@ -64,6 +74,8 @@ void main() {
6474
Platform: () => linuxPlatform,
6575
ProcessManager: () => FakeProcessManager.any(),
6676
Logger: () => BufferLogger.test(),
77+
FeatureFlags: enableExplicitPackageDependencies,
78+
Pub: FakePubWithPrimedDeps.new,
6779
});
6880

6981
testUsingContext('TestCompiler does not try to cache the dill file when precompiled dill is passed', () async {
@@ -81,6 +93,8 @@ void main() {
8193
Platform: () => linuxPlatform,
8294
ProcessManager: () => FakeProcessManager.any(),
8395
Logger: () => BufferLogger.test(),
96+
FeatureFlags: enableExplicitPackageDependencies,
97+
Pub: FakePubWithPrimedDeps.new,
8498
});
8599

86100
testUsingContext('TestCompiler reports null when a compile fails', () async {
@@ -98,6 +112,8 @@ void main() {
98112
Platform: () => linuxPlatform,
99113
ProcessManager: () => FakeProcessManager.any(),
100114
Logger: () => BufferLogger.test(),
115+
FeatureFlags: enableExplicitPackageDependencies,
116+
Pub: FakePubWithPrimedDeps.new,
101117
});
102118

103119

@@ -126,6 +142,8 @@ void main() {
126142
Platform: () => linuxPlatform,
127143
ProcessManager: () => FakeProcessManager.any(),
128144
Logger: () => logger,
145+
FeatureFlags: enableExplicitPackageDependencies,
146+
Pub: FakePubWithPrimedDeps.new,
129147
});
130148

131149
testUsingContext('TestCompiler disposing test compiler shuts down backing compiler', () async {
@@ -147,6 +165,8 @@ void main() {
147165
Platform: () => linuxPlatform,
148166
ProcessManager: () => FakeProcessManager.any(),
149167
Logger: () => BufferLogger.test(),
168+
FeatureFlags: enableExplicitPackageDependencies,
169+
Pub: FakePubWithPrimedDeps.new,
150170
});
151171

152172
testUsingContext('TestCompiler updates dart_plugin_registrant.dart', () async {
@@ -212,6 +232,8 @@ environment:
212232
Platform: () => linuxPlatform,
213233
ProcessManager: () => FakeProcessManager.any(),
214234
Logger: () => BufferLogger.test(),
235+
FeatureFlags: enableExplicitPackageDependencies,
236+
Pub: FakePubWithPrimedDeps.new,
215237
});
216238
}
217239

0 commit comments

Comments
 (0)