Skip to content

Commit 4e27f34

Browse files
author
Jonah Williams
authored
[Impeller] skip perspective transformed text goldens. (#143623)
Part of flutter/flutter#143616 The perspective transformed text goldens are super unstable, possibly for the same reason they are in flutter/engine.
1 parent bb1c7a6 commit 4e27f34

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

packages/flutter/test/cupertino/date_picker_test.dart

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ import 'package:flutter/material.dart';
1515
import 'package:flutter/rendering.dart';
1616
import 'package:flutter_test/flutter_test.dart';
1717

18+
import '../impeller_test_helpers.dart';
19+
1820
// TODO(yjbanov): on the web text rendered with perspective produces flaky goldens: https://github.com/flutter/flutter/issues/110785
1921
const bool skipPerspectiveTextGoldens = isBrowser;
2022

@@ -1607,7 +1609,7 @@ void main() {
16071609
matchesGoldenFile('date_picker_test.datetime.drag.png'),
16081610
);
16091611
}
1610-
});
1612+
}, skip: impellerEnabled); // https://github.com/flutter/flutter/issues/143616
16111613

16121614
testWidgets('DatePicker displays the date in correct order', (WidgetTester tester) async {
16131615
await tester.pumpWidget(
@@ -1752,7 +1754,7 @@ void main() {
17521754
matchesGoldenFile('timer_picker_test.datetime.drag.png'),
17531755
);
17541756
}
1755-
});
1757+
}, skip: impellerEnabled); // https://github.com/flutter/flutter/issues/143616
17561758

17571759
testWidgets('TimerPicker only changes hour label after scrolling stops', (WidgetTester tester) async {
17581760
Duration? duration;

0 commit comments

Comments
 (0)