Skip to content

Commit 8731c39

Browse files
mdebbarmdebbar
authored
[web] Make FLUTTER_WEB_AUTO_DETECT false by default (#160191)
Now that "auto" is not supported anymore, it makes more sense to make this dart define false by default. And there's no need to pass `FLUTTER_WEB_AUTO_DETECT=false` anymore.
1 parent afc68e3 commit 8731c39

File tree

7 files changed

+11
-89
lines changed

7 files changed

+11
-89
lines changed

‎dev/bots/suite_runners/run_web_tests.dart‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -376,7 +376,6 @@ class WebTestsSuite {
376376
'web-server',
377377
'--$buildMode',
378378
// '--web-renderer=$webRenderer',
379-
'--dart-define=FLUTTER_WEB_AUTO_DETECT=false',
380379
if (webRenderer == 'skwasm') ...<String>[
381380
// See: WebRendererMode.dartDefines[skwasm]
382381
'--dart-define=FLUTTER_WEB_USE_SKIA=false',
@@ -513,7 +512,6 @@ class WebTestsSuite {
513512
'drive',
514513
if (canvasKit) '--dart-define=FLUTTER_WEB_USE_SKIA=true',
515514
if (!canvasKit) '--dart-define=FLUTTER_WEB_USE_SKIA=false',
516-
if (!canvasKit) '--dart-define=FLUTTER_WEB_AUTO_DETECT=false',
517515
'--driver=test_driver/transitions_perf_e2e_test.dart',
518516
'--target=test_driver/transitions_perf_e2e.dart',
519517
'--browser-name=chrome',
@@ -575,7 +573,6 @@ class WebTestsSuite {
575573
'chrome',
576574
'--web-run-headless',
577575
'--dart-define=FLUTTER_WEB_USE_SKIA=false',
578-
'--dart-define=FLUTTER_WEB_AUTO_DETECT=false',
579576
...additionalArguments,
580577
'-t',
581578
target,
@@ -742,7 +739,6 @@ class WebTestsSuite {
742739
'-v',
743740
'--platform=chrome',
744741
if (useWasm) '--wasm',
745-
'--dart-define=FLUTTER_WEB_AUTO_DETECT=false',
746742
// '--web-renderer=$webRenderer',
747743
if (webRenderer == 'skwasm') ...<String>[
748744
// See: WebRendererMode.dartDefines[skwasm]

‎engine/src/flutter/lib/web_ui/dev/steps/compile_bundle_step.dart‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -217,10 +217,6 @@ class Dart2JSCompiler extends TestCompiler {
217217
'--disable-inlining',
218218
'--enable-asserts',
219219

220-
// We do not want to auto-select a renderer in tests. As of today, tests
221-
// are designed to run in one specific mode. So instead, we specify the
222-
// renderer explicitly.
223-
'-DFLUTTER_WEB_AUTO_DETECT=false',
224220
'-DFLUTTER_WEB_USE_SKIA=${renderer == Renderer.canvaskit}',
225221
'-DFLUTTER_WEB_USE_SKWASM=${renderer == Renderer.skwasm}',
226222

@@ -279,10 +275,6 @@ class Dart2WasmCompiler extends TestCompiler {
279275
'--enable-asserts',
280276
'--enable-experimental-wasm-interop',
281277

282-
// We do not want to auto-select a renderer in tests. As of today, tests
283-
// are designed to run in one specific mode. So instead, we specify the
284-
// renderer explicitly.
285-
'-DFLUTTER_WEB_AUTO_DETECT=false',
286278
'-DFLUTTER_WEB_USE_SKIA=${renderer == Renderer.canvaskit}',
287279
'-DFLUTTER_WEB_USE_SKWASM=${renderer == Renderer.skwasm}',
288280

‎engine/src/flutter/lib/web_ui/lib/src/engine/configuration.dart‎

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -174,12 +174,9 @@ class FlutterConfiguration {
174174

175175
/// Auto detect which rendering backend to use.
176176
///
177-
/// Using flutter tools option "--web-renderer=auto" or not specifying one
178-
/// would set the value to true. Otherwise, it would be false.
179-
static const bool flutterWebAutoDetect = bool.fromEnvironment(
180-
'FLUTTER_WEB_AUTO_DETECT',
181-
defaultValue: true,
182-
);
177+
/// Using flutter tools option "--web-renderer=auto" would set the value to
178+
/// true. Otherwise, it would be false.
179+
static const bool flutterWebAutoDetect = bool.fromEnvironment('FLUTTER_WEB_AUTO_DETECT');
183180

184181
static const bool flutterWebUseSkwasm = bool.fromEnvironment('FLUTTER_WEB_USE_SKWASM');
185182

‎packages/flutter_tools/lib/src/web/compile.dart‎

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -239,21 +239,9 @@ enum WebRendererMode {
239239

240240
Iterable<String> get dartDefines => switch (this) {
241241
auto => const <String>{'FLUTTER_WEB_AUTO_DETECT=true'},
242-
canvaskit => const <String>{
243-
'FLUTTER_WEB_AUTO_DETECT=false',
244-
'FLUTTER_WEB_USE_SKIA=true',
245-
'FLUTTER_WEB_USE_SKWASM=false',
246-
},
247-
html => const <String>{
248-
'FLUTTER_WEB_AUTO_DETECT=false',
249-
'FLUTTER_WEB_USE_SKIA=false',
250-
'FLUTTER_WEB_USE_SKWASM=false',
251-
},
252-
skwasm => const <String>{
253-
'FLUTTER_WEB_AUTO_DETECT=false',
254-
'FLUTTER_WEB_USE_SKIA=false',
255-
'FLUTTER_WEB_USE_SKWASM=true',
256-
},
242+
canvaskit => const <String>{'FLUTTER_WEB_USE_SKIA=true', 'FLUTTER_WEB_USE_SKWASM=false'},
243+
html => const <String>{'FLUTTER_WEB_USE_SKIA=false', 'FLUTTER_WEB_USE_SKWASM=false'},
244+
skwasm => const <String>{'FLUTTER_WEB_USE_SKIA=false', 'FLUTTER_WEB_USE_SKWASM=true'},
257245
};
258246

259247
/// Sets the dart defines for the currently selected WebRendererMode

‎packages/flutter_tools/test/general.shard/build_system/targets/web_defines_test.dart‎

Lines changed: 5 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -20,20 +20,12 @@ void main() {
2020

2121
test('canvaskit web-renderer with no dart-defines', () {
2222
dartDefines = WebRendererMode.canvaskit.updateDartDefines(dartDefines);
23-
expect(dartDefines, <String>[
24-
'FLUTTER_WEB_AUTO_DETECT=false',
25-
'FLUTTER_WEB_USE_SKIA=true',
26-
'FLUTTER_WEB_USE_SKWASM=false',
27-
]);
23+
expect(dartDefines, <String>['FLUTTER_WEB_USE_SKIA=true', 'FLUTTER_WEB_USE_SKWASM=false']);
2824
});
2925

3026
test('html web-renderer with no dart-defines', () {
3127
dartDefines = WebRendererMode.html.updateDartDefines(dartDefines);
32-
expect(dartDefines, <String>[
33-
'FLUTTER_WEB_AUTO_DETECT=false',
34-
'FLUTTER_WEB_USE_SKIA=false',
35-
'FLUTTER_WEB_USE_SKWASM=false',
36-
]);
28+
expect(dartDefines, <String>['FLUTTER_WEB_USE_SKIA=false', 'FLUTTER_WEB_USE_SKWASM=false']);
3729
});
3830

3931
test('auto web-renderer with existing dart-defines', () {
@@ -45,31 +37,19 @@ void main() {
4537
test('canvaskit web-renderer with existing dart-defines', () {
4638
dartDefines = <String>['FLUTTER_WEB_USE_SKIA=false'];
4739
dartDefines = WebRendererMode.canvaskit.updateDartDefines(dartDefines);
48-
expect(dartDefines, <String>[
49-
'FLUTTER_WEB_AUTO_DETECT=false',
50-
'FLUTTER_WEB_USE_SKIA=true',
51-
'FLUTTER_WEB_USE_SKWASM=false',
52-
]);
40+
expect(dartDefines, <String>['FLUTTER_WEB_USE_SKIA=true', 'FLUTTER_WEB_USE_SKWASM=false']);
5341
});
5442

5543
test('html web-renderer with existing dart-defines', () {
5644
dartDefines = <String>['FLUTTER_WEB_USE_SKIA=true'];
5745
dartDefines = WebRendererMode.html.updateDartDefines(dartDefines);
58-
expect(dartDefines, <String>[
59-
'FLUTTER_WEB_AUTO_DETECT=false',
60-
'FLUTTER_WEB_USE_SKIA=false',
61-
'FLUTTER_WEB_USE_SKWASM=false',
62-
]);
46+
expect(dartDefines, <String>['FLUTTER_WEB_USE_SKIA=false', 'FLUTTER_WEB_USE_SKWASM=false']);
6347
});
6448

6549
test('skwasm web-renderer with existing dart-defines', () {
6650
dartDefines = <String>['FLUTTER_WEB_USE_SKWASM=false'];
6751
dartDefines = WebRendererMode.skwasm.updateDartDefines(dartDefines);
68-
expect(dartDefines, <String>[
69-
'FLUTTER_WEB_AUTO_DETECT=false',
70-
'FLUTTER_WEB_USE_SKIA=false',
71-
'FLUTTER_WEB_USE_SKWASM=true',
72-
]);
52+
expect(dartDefines, <String>['FLUTTER_WEB_USE_SKIA=false', 'FLUTTER_WEB_USE_SKWASM=true']);
7353
});
7454
});
7555
}

‎packages/flutter_tools/test/general.shard/build_system/targets/web_test.dart‎

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -501,7 +501,6 @@ void main() {
501501
command: <String>[
502502
..._kDart2jsLinuxArgs,
503503
'-Ddart.vm.profile=true',
504-
'-DFLUTTER_WEB_AUTO_DETECT=false',
505504
'-DFLUTTER_WEB_USE_SKIA=true',
506505
'-DFLUTTER_WEB_USE_SKWASM=false',
507506
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
@@ -519,7 +518,6 @@ void main() {
519518
command: <String>[
520519
..._kDart2jsLinuxArgs,
521520
'-Ddart.vm.profile=true',
522-
'-DFLUTTER_WEB_AUTO_DETECT=false',
523521
'-DFLUTTER_WEB_USE_SKIA=true',
524522
'-DFLUTTER_WEB_USE_SKWASM=false',
525523
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
@@ -548,7 +546,6 @@ void main() {
548546
command: <String>[
549547
..._kDart2jsLinuxArgs,
550548
'-Ddart.vm.profile=true',
551-
'-DFLUTTER_WEB_AUTO_DETECT=false',
552549
'-DFLUTTER_WEB_USE_SKIA=true',
553550
'-DFLUTTER_WEB_USE_SKWASM=false',
554551
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
@@ -566,7 +563,6 @@ void main() {
566563
command: <String>[
567564
..._kDart2jsLinuxArgs,
568565
'-Ddart.vm.profile=true',
569-
'-DFLUTTER_WEB_AUTO_DETECT=false',
570566
'-DFLUTTER_WEB_USE_SKIA=true',
571567
'-DFLUTTER_WEB_USE_SKWASM=false',
572568
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
@@ -595,7 +591,6 @@ void main() {
595591
..._kDart2jsLinuxArgs,
596592
'--enable-experiment=non-nullable',
597593
'-Ddart.vm.profile=true',
598-
'-DFLUTTER_WEB_AUTO_DETECT=false',
599594
'-DFLUTTER_WEB_USE_SKIA=true',
600595
'-DFLUTTER_WEB_USE_SKWASM=false',
601596
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
@@ -614,7 +609,6 @@ void main() {
614609
..._kDart2jsLinuxArgs,
615610
'--enable-experiment=non-nullable',
616611
'-Ddart.vm.profile=true',
617-
'-DFLUTTER_WEB_AUTO_DETECT=false',
618612
'-DFLUTTER_WEB_USE_SKIA=true',
619613
'-DFLUTTER_WEB_USE_SKWASM=false',
620614
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
@@ -641,7 +635,6 @@ void main() {
641635
command: <String>[
642636
..._kDart2jsLinuxArgs,
643637
'-Ddart.vm.profile=true',
644-
'-DFLUTTER_WEB_AUTO_DETECT=false',
645638
'-DFLUTTER_WEB_USE_SKIA=true',
646639
'-DFLUTTER_WEB_USE_SKWASM=false',
647640
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
@@ -659,7 +652,6 @@ void main() {
659652
command: <String>[
660653
..._kDart2jsLinuxArgs,
661654
'-Ddart.vm.profile=true',
662-
'-DFLUTTER_WEB_AUTO_DETECT=false',
663655
'-DFLUTTER_WEB_USE_SKIA=true',
664656
'-DFLUTTER_WEB_USE_SKWASM=false',
665657
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
@@ -686,7 +678,6 @@ void main() {
686678
command: <String>[
687679
..._kDart2jsLinuxArgs,
688680
'-Ddart.vm.product=true',
689-
'-DFLUTTER_WEB_AUTO_DETECT=false',
690681
'-DFLUTTER_WEB_USE_SKIA=true',
691682
'-DFLUTTER_WEB_USE_SKWASM=false',
692683
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
@@ -704,7 +695,6 @@ void main() {
704695
command: <String>[
705696
..._kDart2jsLinuxArgs,
706697
'-Ddart.vm.product=true',
707-
'-DFLUTTER_WEB_AUTO_DETECT=false',
708698
'-DFLUTTER_WEB_USE_SKIA=true',
709699
'-DFLUTTER_WEB_USE_SKWASM=false',
710700
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
@@ -731,7 +721,6 @@ void main() {
731721
command: <String>[
732722
..._kDart2jsLinuxArgs,
733723
'-Ddart.vm.product=true',
734-
'-DFLUTTER_WEB_AUTO_DETECT=false',
735724
'-DFLUTTER_WEB_USE_SKIA=true',
736725
'-DFLUTTER_WEB_USE_SKWASM=false',
737726
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
@@ -750,7 +739,6 @@ void main() {
750739
command: <String>[
751740
..._kDart2jsLinuxArgs,
752741
'-Ddart.vm.product=true',
753-
'-DFLUTTER_WEB_AUTO_DETECT=false',
754742
'-DFLUTTER_WEB_USE_SKIA=true',
755743
'-DFLUTTER_WEB_USE_SKWASM=false',
756744
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
@@ -779,7 +767,6 @@ void main() {
779767
command: <String>[
780768
..._kDart2jsLinuxArgs,
781769
'-Ddart.vm.product=true',
782-
'-DFLUTTER_WEB_AUTO_DETECT=false',
783770
'-DFLUTTER_WEB_USE_SKIA=true',
784771
'-DFLUTTER_WEB_USE_SKWASM=false',
785772
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
@@ -797,7 +784,6 @@ void main() {
797784
command: <String>[
798785
..._kDart2jsLinuxArgs,
799786
'-Ddart.vm.product=true',
800-
'-DFLUTTER_WEB_AUTO_DETECT=false',
801787
'-DFLUTTER_WEB_USE_SKIA=true',
802788
'-DFLUTTER_WEB_USE_SKWASM=false',
803789
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
@@ -825,7 +811,6 @@ void main() {
825811
command: <String>[
826812
..._kDart2jsLinuxArgs,
827813
'-Ddart.vm.product=true',
828-
'-DFLUTTER_WEB_AUTO_DETECT=false',
829814
'-DFLUTTER_WEB_USE_SKIA=true',
830815
'-DFLUTTER_WEB_USE_SKWASM=false',
831816
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
@@ -846,7 +831,6 @@ void main() {
846831
command: <String>[
847832
..._kDart2jsLinuxArgs,
848833
'-Ddart.vm.product=true',
849-
'-DFLUTTER_WEB_AUTO_DETECT=false',
850834
'-DFLUTTER_WEB_USE_SKIA=true',
851835
'-DFLUTTER_WEB_USE_SKWASM=false',
852836
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
@@ -886,7 +870,6 @@ void main() {
886870
'-Ddart.vm.product=true',
887871
'-DFOO=bar',
888872
'-DBAZ=qux',
889-
'-DFLUTTER_WEB_AUTO_DETECT=false',
890873
'-DFLUTTER_WEB_USE_SKIA=true',
891874
'-DFLUTTER_WEB_USE_SKWASM=false',
892875
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
@@ -906,7 +889,6 @@ void main() {
906889
'-Ddart.vm.product=true',
907890
'-DFOO=bar',
908891
'-DBAZ=qux',
909-
'-DFLUTTER_WEB_AUTO_DETECT=false',
910892
'-DFLUTTER_WEB_USE_SKIA=true',
911893
'-DFLUTTER_WEB_USE_SKWASM=false',
912894
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
@@ -933,7 +915,6 @@ void main() {
933915
command: <String>[
934916
..._kDart2jsLinuxArgs,
935917
'-Ddart.vm.product=true',
936-
'-DFLUTTER_WEB_AUTO_DETECT=false',
937918
'-DFLUTTER_WEB_USE_SKIA=true',
938919
'-DFLUTTER_WEB_USE_SKWASM=false',
939920
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
@@ -950,7 +931,6 @@ void main() {
950931
command: <String>[
951932
..._kDart2jsLinuxArgs,
952933
'-Ddart.vm.product=true',
953-
'-DFLUTTER_WEB_AUTO_DETECT=false',
954934
'-DFLUTTER_WEB_USE_SKIA=true',
955935
'-DFLUTTER_WEB_USE_SKWASM=false',
956936
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
@@ -978,7 +958,6 @@ void main() {
978958
'-Ddart.vm.profile=true',
979959
'-DFOO=bar',
980960
'-DBAZ=qux',
981-
'-DFLUTTER_WEB_AUTO_DETECT=false',
982961
'-DFLUTTER_WEB_USE_SKIA=true',
983962
'-DFLUTTER_WEB_USE_SKWASM=false',
984963
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
@@ -998,7 +977,6 @@ void main() {
998977
'-Ddart.vm.profile=true',
999978
'-DFOO=bar',
1000979
'-DBAZ=qux',
1001-
'-DFLUTTER_WEB_AUTO_DETECT=false',
1002980
'-DFLUTTER_WEB_USE_SKIA=true',
1003981
'-DFLUTTER_WEB_USE_SKWASM=false',
1004982
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
@@ -1027,7 +1005,6 @@ void main() {
10271005
..._kDart2jsLinuxArgs,
10281006
'-DFOO=bar',
10291007
'-DBAZ=qux',
1030-
'-DFLUTTER_WEB_AUTO_DETECT=false',
10311008
'-DFLUTTER_WEB_USE_SKIA=true',
10321009
'-DFLUTTER_WEB_USE_SKWASM=false',
10331010
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
@@ -1047,7 +1024,6 @@ void main() {
10471024
..._kDart2jsLinuxArgs,
10481025
'-DFOO=bar',
10491026
'-DBAZ=qux',
1050-
'-DFLUTTER_WEB_AUTO_DETECT=false',
10511027
'-DFLUTTER_WEB_USE_SKIA=true',
10521028
'-DFLUTTER_WEB_USE_SKWASM=false',
10531029
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
@@ -1076,7 +1052,6 @@ void main() {
10761052
command: <String>[
10771053
..._kDart2jsLinuxArgs,
10781054
'-Ddart.vm.profile=true',
1079-
'-DFLUTTER_WEB_AUTO_DETECT=false',
10801055
'-DFLUTTER_WEB_USE_SKIA=true',
10811056
'-DFLUTTER_WEB_USE_SKWASM=false',
10821057
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
@@ -1094,7 +1069,6 @@ void main() {
10941069
command: <String>[
10951070
..._kDart2jsLinuxArgs,
10961071
'-Ddart.vm.profile=true',
1097-
'-DFLUTTER_WEB_AUTO_DETECT=false',
10981072
'-DFLUTTER_WEB_USE_SKIA=true',
10991073
'-DFLUTTER_WEB_USE_SKWASM=false',
11001074
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
@@ -1125,7 +1099,6 @@ void main() {
11251099
command: <String>[
11261100
..._kDart2jsLinuxArgs,
11271101
'-Ddart.vm.profile=true',
1128-
'-DFLUTTER_WEB_AUTO_DETECT=false',
11291102
'-DFLUTTER_WEB_USE_SKIA=true',
11301103
'-DFLUTTER_WEB_USE_SKWASM=false',
11311104
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
@@ -1143,7 +1116,6 @@ void main() {
11431116
command: <String>[
11441117
..._kDart2jsLinuxArgs,
11451118
'-Ddart.vm.profile=true',
1146-
'-DFLUTTER_WEB_AUTO_DETECT=false',
11471119
'-DFLUTTER_WEB_USE_SKIA=true',
11481120
'-DFLUTTER_WEB_USE_SKWASM=false',
11491121
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
@@ -1201,12 +1173,10 @@ void main() {
12011173
],
12021174
...defines.map((String define) => '-D$define'),
12031175
if (renderer == WebRendererMode.skwasm) ...<String>[
1204-
'-DFLUTTER_WEB_AUTO_DETECT=false',
12051176
'-DFLUTTER_WEB_USE_SKIA=false',
12061177
'-DFLUTTER_WEB_USE_SKWASM=true',
12071178
],
12081179
if (renderer == WebRendererMode.canvaskit) ...<String>[
1209-
'-DFLUTTER_WEB_AUTO_DETECT=false',
12101180
'-DFLUTTER_WEB_USE_SKIA=true',
12111181
'-DFLUTTER_WEB_USE_SKWASM=false',
12121182
],

‎packages/flutter_tools/test/general.shard/test/web_test_compiler_test.dart‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ void main() {
4343
'--incremental',
4444
'--target=dartdevc',
4545
'--experimental-emit-debug-metadata',
46-
'-DFLUTTER_WEB_AUTO_DETECT=false',
4746
'-DFLUTTER_WEB_USE_SKIA=true',
4847
'-DFLUTTER_WEB_USE_SKWASM=false',
4948
'--output-dill',

0 commit comments

Comments
 (0)