[camerax] Ensure DeviceOrientationManager stops on dispose (flutter#9141)

This ensures DeviceOrientationManager is released on dispose. Prevents
leaked IntentReceiver on close.

Fixes: flutter/flutter#166529

## Pre-Review Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] page, which explains my
responsibilities.
- [X] I read and followed the [relevant style guides] and ran [the
auto-formatter].
- [X] I signed the [CLA].
- [X] The title of the PR starts with the name of the package surrounded
by square brackets, e.g. `[shared_preferences]`
- [X] I [linked to at least one issue that this PR fixes] in the
description above.
- [X] I updated `pubspec.yaml` with an appropriate new version according
to the [pub versioning philosophy], or I have commented below to
indicate which [version change exemption] this PR falls under[^1].
- [X] I updated `CHANGELOG.md` to add a description of the change,
[following repository CHANGELOG style], or I have commented below to
indicate which [CHANGELOG exemption] this PR falls under[^1].
- [X] I updated/added any relevant documentation (doc comments with
`///`).
- [X] I added new tests to check the change I am making, or I have
commented below to indicate which [test exemption] this PR falls
under[^1].
- [X] All existing and new tests are passing.

Author: mboetger

packages/camera/camera_android_camerax/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.6.15+1
+
+* Ensures DeviceOrientationManager is stopped on dispose.
+
 ## 0.6.15
 
 * Updates internal API wrapper to use ProxyApis.

packages/camera/camera_android_camerax/lib/src/android_camera_camerax.dart

@@ -493,6 +493,7 @@ class AndroidCameraCameraX extends CameraPlatform {
     await liveCameraState?.removeObservers();
     await processCameraProvider?.unbindAll();
     await imageAnalysis?.clearAnalyzer();
+    await deviceOrientationManager.stopListeningForDeviceOrientationChange();
   }
 
   /// The camera has been initialized.

packages/camera/camera_android_camerax/pubspec.yaml

@@ -2,7 +2,7 @@ name: camera_android_camerax
 description: Android implementation of the camera plugin using the CameraX library.
 repository: https://github.com/flutter/packages/tree/main/packages/camera/camera_android_camerax
 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+camera%22
-version: 0.6.15
+version: 0.6.15+1
 
 environment:
   sdk: ^3.6.0

packages/camera/camera_android_camerax/test/android_camera_camerax_test.dart

@@ -2205,7 +2205,30 @@ void main() {
   test(
     'dispose releases Flutter surface texture, removes camera state observers, and unbinds all use cases',
     () async {
+      bool stoppedListeningForDeviceOrientationChange = false;
       final AndroidCameraCameraX camera = AndroidCameraCameraX();
+      camera.proxy = CameraXProxy(
+        newDeviceOrientationManager: ({
+          required void Function(DeviceOrientationManager, String)
+              onDeviceOrientationChanged,
+          // ignore: non_constant_identifier_names
+          BinaryMessenger? pigeon_binaryMessenger,
+          // ignore: non_constant_identifier_names
+          PigeonInstanceManager? pigeon_instanceManager,
+        }) {
+          final MockDeviceOrientationManager mockDeviceOrientationManager =
+              MockDeviceOrientationManager();
+          when(
+            mockDeviceOrientationManager
+                .stopListeningForDeviceOrientationChange(),
+          ).thenAnswer((
+            _,
+          ) async {
+            stoppedListeningForDeviceOrientationChange = true;
+          });
+          return mockDeviceOrientationManager;
+        },
+      );
 
       camera.preview = MockPreview();
       camera.processCameraProvider = MockProcessCameraProvider();
@@ -2218,6 +2241,7 @@ void main() {
       verify(camera.liveCameraState!.removeObservers());
       verify(camera.processCameraProvider!.unbindAll());
       verify(camera.imageAnalysis!.clearAnalyzer());
+      expect(stoppedListeningForDeviceOrientationChange, isTrue);
     },
   );