Skip to content

Commit bdfb56c

Browse files
authored
Only run dart files as a test in the Android preview tools test shard (#140099)
I added a README at the end of flutter/flutter#131901 and did not realize that it was being run as a test, [leading to test failures (of course)](https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8761789207346423409/+/u/run_test.dart_for_android_preview_tool_integration_tests_shard_and_subshard_None/test_stdout). This makes it so we only run dart files as dart tests.
1 parent a17e2e0 commit bdfb56c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

dev/bots/test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -482,7 +482,7 @@ Future<void> _runAndroidPreviewIntegrationToolTests() async {
482482
final List<String> allTests = Directory(path.join(_toolsPath, 'test', 'android_preview_integration.shard'))
483483
.listSync(recursive: true).whereType<File>()
484484
.map<String>((FileSystemEntity entry) => path.relative(entry.path, from: _toolsPath))
485-
.toList();
485+
.where((String testPath) => path.basename(testPath).endsWith('_test.dart')).toList();
486486

487487
await _runDartTest(
488488
_toolsPath,

0 commit comments

Comments
 (0)