Skip to content

Commit c155e30

Browse files
small update in regex in flutter.groovy (#156484)
see #147122 for more context `/(\\ |[^\s])+/ ` and `/(\\ |\S)+/` are basically equivalant but the last one won't trigger android Studio warnings ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md Co-authored-by: Andrew Kolos <andrewrkolos@gmail.com>
1 parent cedd859 commit c155e30

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

packages/flutter_tools/gradle/src/main/groovy/flutter.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1793,7 +1793,7 @@ class FlutterTask extends BaseFlutterTask {
17931793
// <target> <files>: <source> <files> <separated> <by> <non-escaped space>
17941794
String depText = dependenciesFile.text
17951795
// So we split list of files by non-escaped(by backslash) space,
1796-
def matcher = depText.split(": ")[inputs ? 1 : 0] =~ /(\\ |[^\s])+/
1796+
def matcher = depText.split(": ")[inputs ? 1 : 0] =~ /(\\ |\S)+/
17971797
// then we replace all escaped spaces with regular spaces
17981798
def depList = matcher.collect{ it[0].replaceAll("\\\\ ", " ") }
17991799
return project.files(depList)

0 commit comments

Comments
 (0)