Skip to content

Commit d6089dd

Browse files
authored
Delete unused build archive targets (#164414)
This migration is incomplete and is no longer planned. Issue: flutter/flutter#105351 ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [X] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
1 parent 87c87c0 commit d6089dd

File tree

1 file changed

+0
-70
lines changed
  • engine/src/flutter/shell/platform/android

1 file changed

+0
-70
lines changed

engine/src/flutter/shell/platform/android/BUILD.gn

Lines changed: 0 additions & 70 deletions
Original file line numberDiff line numberDiff line change
@@ -716,45 +716,6 @@ if (target_cpu != "x86") {
716716
]
717717
}
718718
}
719-
720-
# TODO(godofredoc): Remove gen_snapshot and rename new_gen_snapshot when v2 migration is complete.
721-
# BUG: https://github.com/flutter/flutter/issues/105351
722-
zip_bundle("new_gen_snapshot") {
723-
gen_snapshot_bin = "gen_snapshot"
724-
gen_snapshot_out_dir =
725-
get_label_info("$dart_src/runtime/bin:gen_snapshot($host_toolchain)",
726-
"root_out_dir")
727-
gen_snapshot_path = rebase_path("$gen_snapshot_out_dir/$gen_snapshot_bin")
728-
729-
if (host_os == "linux") {
730-
output = "$android_zip_archive_dir/$full_platform_name-$flutter_runtime_mode/linux-x64.zip"
731-
} else if (host_os == "mac") {
732-
output = "$android_zip_archive_dir/$full_platform_name-$flutter_runtime_mode/darwin-x64.zip"
733-
} else if (host_os == "win") {
734-
output = "$android_zip_archive_dir/$full_platform_name-$flutter_runtime_mode/windows-x64.zip"
735-
gen_snapshot_bin = "gen_snapshot.exe"
736-
gen_snapshot_path = rebase_path("$root_out_dir/$gen_snapshot_bin")
737-
}
738-
739-
files = [
740-
{
741-
source = gen_snapshot_path
742-
destination = gen_snapshot_bin
743-
},
744-
]
745-
746-
deps = [ "$dart_src/runtime/bin:gen_snapshot($host_toolchain)" ]
747-
748-
if (host_os == "mac") {
749-
deps += [ ":android_entitlement_config" ]
750-
files += [
751-
{
752-
source = "$target_gen_dir/android_entitlements.txt"
753-
destination = "entitlements.txt"
754-
},
755-
]
756-
}
757-
}
758719
}
759720

760721
if (host_os == "linux" && (target_cpu == "x64" || target_cpu == "arm64")) {
@@ -786,37 +747,6 @@ if (host_os == "linux" && (target_cpu == "x64" || target_cpu == "arm64")) {
786747
},
787748
]
788749
}
789-
790-
# TODO(godofredoc): Remove analyze_snapshot and rename new_analyze_snapshot when v2 migration is complete.
791-
# BUG: https://github.com/flutter/flutter/issues/105351
792-
zip_bundle("new_analyze_snapshot") {
793-
deps = [ "$dart_src/runtime/bin:analyze_snapshot($host_toolchain)" ]
794-
795-
analyze_snapshot_bin = "analyze_snapshot"
796-
analyze_snapshot_out_dir =
797-
get_label_info(
798-
"$dart_src/runtime/bin:analyze_snapshot($host_toolchain)",
799-
"root_out_dir")
800-
analyze_snapshot_path =
801-
rebase_path("$analyze_snapshot_out_dir/$analyze_snapshot_bin")
802-
803-
if (host_os == "linux") {
804-
output = "$android_zip_archive_dir/$full_platform_name-$flutter_runtime_mode/analyze-snapshot-linux-x64.zip"
805-
} else if (host_os == "mac") {
806-
output = "$android_zip_archive_dir/$full_platform_name-$flutter_runtime_mode/analyze-snapshot-darwin-x64.zip"
807-
} else if (host_os == "win") {
808-
output = "$android_zip_archive_dir/$full_platform_name-$flutter_runtime_mode/analyze-snapshot-windows-x64.zip"
809-
analyze_snapshot_bin = "analyze-snapshot.exe"
810-
analyze_snapshot_path = rebase_path("$root_out_dir/$analyze_snapshot_bin")
811-
}
812-
813-
files = [
814-
{
815-
source = analyze_snapshot_path
816-
destination = analyze_snapshot_bin
817-
},
818-
]
819-
}
820750
}
821751

822752
group("android") {

0 commit comments

Comments
 (0)