Skip to content

Commit e36ae79

Browse files
Add a carve-out on the commenting requirement (flutter#8855)
I hadn't added anything about a carve-out originally because I couldn't think of a way that wouldn't make the checklist much more confusing, but it occurred to me that a footnote would get it out of the way while still making the exemption explicit.
1 parent 4fc010e commit e36ae79

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,16 @@
1010
- [ ] I signed the [CLA].
1111
- [ ] The title of the PR starts with the name of the package surrounded by square brackets, e.g. `[shared_preferences]`
1212
- [ ] I [linked to at least one issue that this PR fixes] in the description above.
13-
- [ ] I updated `pubspec.yaml` with an appropriate new version according to the [pub versioning philosophy], or I have commented below to indicate which [version change exemption] this PR falls under.
14-
- [ ] I updated `CHANGELOG.md` to add a description of the change, [following repository CHANGELOG style], or I have commented below to indicate which [CHANGELOG exemption] this PR falls under.
13+
- [ ] I updated `pubspec.yaml` with an appropriate new version according to the [pub versioning philosophy], or I have commented below to indicate which [version change exemption] this PR falls under[^1].
14+
- [ ] I updated `CHANGELOG.md` to add a description of the change, [following repository CHANGELOG style], or I have commented below to indicate which [CHANGELOG exemption] this PR falls under[^1].
1515
- [ ] I updated/added any relevant documentation (doc comments with `///`).
16-
- [ ] I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under.
16+
- [ ] I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
1717
- [ ] All existing and new tests are passing.
1818

1919
If you need help, consider asking for advice on the #hackers-new channel on [Discord].
2020

21+
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
22+
2123
<!-- Links -->
2224
[Contributor Guide]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md
2325
[Tree Hygiene]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md

0 commit comments

Comments
 (0)