Skip to content

Commit 003f2b6

Browse files
authored
Pass run and drive --trace-systrace for iOS (#105321)
1 parent 0895130 commit 003f2b6

File tree

5 files changed

+8
-1
lines changed

5 files changed

+8
-1
lines changed

packages/flutter_tools/lib/src/commands/run.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,8 @@ abstract class RunCommandBase extends FlutterCommand with DeviceBasedDevelopment
112112
..addFlag('trace-systrace',
113113
negatable: false,
114114
help: 'Enable tracing to the system tracer. This is only useful on '
115-
'platforms where such a tracer is available (Android and Fuchsia).',
115+
'platforms where such a tracer is available (Android, iOS, '
116+
'macOS and Fuchsia).',
116117
)
117118
..addFlag('trace-skia',
118119
negatable: false,

packages/flutter_tools/lib/src/ios/devices.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -361,6 +361,7 @@ class IOSDevice extends Device {
361361
'--verify-entry-points',
362362
],
363363
if (debuggingOptions.enableSoftwareRendering) '--enable-software-rendering',
364+
if (debuggingOptions.traceSystrace) '--trace-systrace',
364365
if (debuggingOptions.skiaDeterministicRendering) '--skia-deterministic-rendering',
365366
if (debuggingOptions.traceSkia) '--trace-skia',
366367
if (debuggingOptions.traceAllowlist != null) '--trace-allowlist="${debuggingOptions.traceAllowlist}"',

packages/flutter_tools/test/commands.shard/hermetic/drive_test.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -224,6 +224,7 @@ void main() {
224224
'--null-assertions',
225225
'--native-null-assertions',
226226
'--enable-impeller',
227+
'--trace-systrace',
227228
'--enable-software-rendering',
228229
'--skia-deterministic-rendering',
229230
]), throwsToolExit());
@@ -238,6 +239,7 @@ void main() {
238239
expect(options.nullAssertions, true);
239240
expect(options.nativeNullAssertions, true);
240241
expect(options.enableImpeller, true);
242+
expect(options.traceSystrace, true);
241243
expect(options.enableSoftwareRendering, true);
242244
expect(options.skiaDeterministicRendering, true);
243245
}, overrides: <Type, Generator>{

packages/flutter_tools/test/commands.shard/hermetic/run_test.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -734,6 +734,7 @@ void main() {
734734
'--null-assertions',
735735
'--native-null-assertions',
736736
'--enable-impeller',
737+
'--trace-systrace',
737738
'--enable-software-rendering',
738739
'--skia-deterministic-rendering',
739740
]), throwsToolExit());
@@ -748,6 +749,7 @@ void main() {
748749
expect(options.verboseSystemLogs, true);
749750
expect(options.nullAssertions, true);
750751
expect(options.nativeNullAssertions, true);
752+
expect(options.traceSystrace, true);
751753
expect(options.enableImpeller, true);
752754
expect(options.enableSoftwareRendering, true);
753755
expect(options.skiaDeterministicRendering, true);

packages/flutter_tools/test/general.shard/ios/ios_device_start_prebuilt_test.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -288,6 +288,7 @@ void main() {
288288
'--enable-checked-mode',
289289
'--verify-entry-points',
290290
'--enable-software-rendering',
291+
'--trace-systrace',
291292
'--skia-deterministic-rendering',
292293
'--trace-skia',
293294
'--endless-trace-buffer',

0 commit comments

Comments
 (0)