Skip to content

Commit 1d59d8d

Browse files
[flutter_tools] increment y instead of m when calling flutter --version on master (#97827)
1 parent 734c3c4 commit 1d59d8d

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

packages/flutter_tools/lib/src/version.dart

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -736,7 +736,9 @@ class GitTagVersion {
736736
return '$x.$y.$z+hotfix.${hotfix! + 1}.pre.$commits';
737737
}
738738
if (devPatch != null && devVersion != null) {
739-
return '$x.$y.$z-${devVersion! + 1}.0.pre.$commits';
739+
// The next published release this commit will appear in will be a beta
740+
// release, thus increment [y].
741+
return '$x.${y! + 1}.0-0.0.pre.$commits';
740742
}
741743
return '$x.$y.${z! + 1}-0.0.pre.$commits';
742744
}

packages/flutter_tools/test/general.shard/version_test.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -372,7 +372,7 @@ void main() {
372372

373373
// Master channel
374374
gitTagVersion = GitTagVersion.parse('1.2.3-4.5.pre-13-g$hash');
375-
expect(gitTagVersion.frameworkVersionFor(hash), '1.2.3-5.0.pre.13');
375+
expect(gitTagVersion.frameworkVersionFor(hash), '1.3.0-0.0.pre.13');
376376
expect(gitTagVersion.gitTag, '1.2.3-4.5.pre');
377377
expect(gitTagVersion.devVersion, 4);
378378
expect(gitTagVersion.devPatch, 5);
@@ -491,8 +491,8 @@ void main() {
491491
logger: BufferLogger.test(),
492492
);
493493
final GitTagVersion gitTagVersion = GitTagVersion.determine(processUtils, workingDirectory: '.');
494-
// reported version should increment the number after the dash
495-
expect(gitTagVersion.frameworkVersionFor(headRevision), '1.2.3-3.0.pre.12');
494+
// reported version should increment the y
495+
expect(gitTagVersion.frameworkVersionFor(headRevision), '1.3.0-0.0.pre.12');
496496
});
497497

498498
testUsingContext('determine does not call fetch --tags', () {

0 commit comments

Comments
 (0)