Fix avoid_redundant_argument_values analyzer warnings enabled in the latest Dart SDK (#103734)

jason-simmons · web-flow · commit 275fb0286ce0 · 2022-05-13T12:57:59.000-07:00
See flutter/flutter#103719
diff --git a/dev/integration_tests/flutter_gallery/lib/demo/material/leave_behind_demo.dart b/dev/integration_tests/flutter_gallery/lib/demo/material/leave_behind_demo.dart
@@ -275,7 +275,6 @@ class _LeaveBehindListItem extends StatelessWidget {
   Future<bool?> _showConfirmationDialog(BuildContext context, String action) {
     return showDialog<bool>(
       context: context,
-      barrierDismissible: true,
       builder: (BuildContext context) {
         return AlertDialog(
           title: Text('Do you want to $action this item?'),
diff --git a/packages/flutter/lib/src/foundation/_isolates_io.dart b/packages/flutter/lib/src/foundation/_isolates_io.dart
@@ -41,7 +41,6 @@ Future<R> compute<Q, R>(isolates.ComputeCallback<Q, R> callback, Q message, { St
         debugLabel,
         flow.id,
       ),
-      errorsAreFatal: true,
       onExit: port.sendPort,
       onError: port.sendPort,
       debugName: debugLabel,
diff --git a/packages/flutter/lib/src/services/system_chrome.dart b/packages/flutter/lib/src/services/system_chrome.dart
@@ -500,7 +500,6 @@ class SystemChrome {
     if (callback != null) {
       await SystemChannels.platform.invokeMethod<void>(
         'SystemChrome.setSystemUIChangeListener',
-        null,
       );
     }
   }
@@ -517,7 +516,6 @@ class SystemChrome {
   static Future<void> restoreSystemUIOverlays() async {
     await SystemChannels.platform.invokeMethod<void>(
       'SystemChrome.restoreSystemUIOverlays',
-      null,
     );
   }
 
diff --git a/packages/flutter/lib/src/widgets/navigator.dart b/packages/flutter/lib/src/widgets/navigator.dart
@@ -5268,7 +5268,7 @@ class _NamedRestorationInformation extends _RestorationInformation {
 
   @override
   Route<dynamic> createRoute(NavigatorState navigator) {
-    final Route<dynamic> route = navigator._routeNamed<dynamic>(name, arguments: arguments, allowNull: false)!;
+    final Route<dynamic> route = navigator._routeNamed<dynamic>(name, arguments: arguments)!;
     assert(route != null);
     return route;
   }
diff --git a/packages/flutter/test/cupertino/route_test.dart b/packages/flutter/test/cupertino/route_test.dart
@@ -1635,7 +1635,6 @@ void main() {
               await showCupertinoModalPopup<void>(
                 context: context,
                 builder: (BuildContext context) => const Text('Visible'),
-                barrierDismissible: true,
               );
             },
             child: const Text('tap'),
diff --git a/packages/flutter/test/material/bottom_sheet_test.dart b/packages/flutter/test/material/bottom_sheet_test.dart
@@ -218,7 +218,6 @@ void main() {
     showModalBottomSheet<void>(
       context: savedContext,
       isDismissible: false,
-      enableDrag: true,
       builder: (BuildContext context) {
         numBuilderCalls++;
         return const Text('BottomSheet');
@@ -323,7 +322,6 @@ void main() {
     showModalBottomSheet<void>(
       context: savedContext,
       builder: (BuildContext context) => const Text('BottomSheet'),
-      isDismissible: true,
     ).then<void>((void value) {
       showBottomSheetThenCalled = true;
     });
@@ -498,7 +496,6 @@ void main() {
     showModalBottomSheet<void>(
       context: savedContext,
       isDismissible: false,
-      enableDrag: true,
       builder: (BuildContext context) => const Text('BottomSheet'),
     ).then<void>((void value) {
       showBottomSheetThenCalled = true;
@@ -531,7 +528,6 @@ void main() {
     showModalBottomSheet<void>(
       context: savedContext,
       isDismissible: false,
-      enableDrag: true,
       builder: (BuildContext context) {
         numBuilderCalls++;
         return const Text('BottomSheet');
diff --git a/packages/flutter/test/material/dialog_test.dart b/packages/flutter/test/material/dialog_test.dart
@@ -1648,7 +1648,6 @@ void main() {
     Future<bool?> confirmDismiss (DismissDirection dismissDirection) async {
       return showDialog<bool>(
         context: scaffoldKey.currentContext!,
-        barrierDismissible: true, // showDialog() returns null if tapped outside the dialog
         builder: (BuildContext context) {
           return AlertDialog(
             actions: <Widget>[
diff --git a/packages/flutter/test/widgets/routes_test.dart b/packages/flutter/test/widgets/routes_test.dart
@@ -1019,7 +1019,6 @@ void main() {
               onPressed: () {
                 showGeneralDialog<void>(
                   context: context,
-                  barrierDismissible: false,
                   transitionDuration: Duration.zero,
                   pageBuilder: (BuildContext innerContext, _, __) {
                     return const SizedBox();
@@ -1097,7 +1096,6 @@ void main() {
                   onPressed: () {
                     showGeneralDialog<void>(
                       context: context,
-                      barrierDismissible: false,
                       transitionDuration: Duration.zero,
                       pageBuilder: (BuildContext innerContext, _, __) {
                         return const SizedBox();
@@ -1135,7 +1133,6 @@ void main() {
                     showGeneralDialog<void>(
                       useRootNavigator: false,
                       context: context,
-                      barrierDismissible: false,
                       transitionDuration: Duration.zero,
                       pageBuilder: (BuildContext innerContext, _, __) {
                         return const SizedBox();
diff --git a/packages/flutter_tools/lib/src/android/android_workflow.dart b/packages/flutter_tools/lib/src/android/android_workflow.dart
@@ -402,12 +402,12 @@ class AndroidLicenseValidator extends DoctorValidator {
         .transform<String>(const Utf8Decoder(reportErrors: false))
         .transform<String>(const LineSplitter())
         .listen(handleLine)
-        .asFuture<void>(null);
+        .asFuture<void>();
       final Future<void> errors = process.stderr
         .transform<String>(const Utf8Decoder(reportErrors: false))
         .transform<String>(const LineSplitter())
         .listen(handleLine)
-        .asFuture<void>(null);
+        .asFuture<void>();
       await Future.wait<void>(<Future<void>>[output, errors]);
       return status ?? LicensesAccepted.unknown;
     } on ProcessException catch (e) {
diff --git a/packages/flutter_tools/lib/src/base/process.dart b/packages/flutter_tools/lib/src/base/process.dart
@@ -295,11 +295,11 @@ class _DefaultProcessUtils implements ProcessUtils {
       final Future<void> stdoutFuture = process.stdout
           .transform<String>(const Utf8Decoder(reportErrors: false))
           .listen(stdoutBuffer.write)
-          .asFuture<void>(null);
+          .asFuture<void>();
       final Future<void> stderrFuture = process.stderr
           .transform<String>(const Utf8Decoder(reportErrors: false))
           .listen(stderrBuffer.write)
-          .asFuture<void>(null);
+          .asFuture<void>();
 
       int? exitCode;
       exitCode = await process.exitCode.then<int?>((int x) => x).timeout(timeout, onTimeout: () {
diff --git a/packages/flutter_web_plugins/test/plugin_event_channel_test.dart b/packages/flutter_web_plugins/test/plugin_event_channel_test.dart
@@ -93,7 +93,7 @@ void main() {
           PluginEventChannel<String>('test3');
 
       final StreamController<String> controller = StreamController<String>(
-          onListen: expectAsync0<void>(() {}, count: 1));
+          onListen: expectAsync0<void>(() {}));
       sendingChannel.setController(controller);
 
       expect(listeningChannel.receiveBroadcastStream(),
@@ -109,7 +109,7 @@ void main() {
           PluginEventChannel<String>('test3');
 
       final StreamController<String> controller = StreamController<String>(
-          onListen: expectAsync0<void>(() {}, count: 1));
+          onListen: expectAsync0<void>(() {}));
       sendingChannel.setController(controller);
 
       expect(listeningChannel.receiveBroadcastStream(),
diff --git a/packages/integration_test/lib/_callback_io.dart b/packages/integration_test/lib/_callback_io.dart
@@ -73,15 +73,13 @@ class IOCallbackManager implements CallbackManager {
     assert(!_isSurfaceRendered, 'Surface already converted to an image');
     await integrationTestChannel.invokeMethod<void>(
       'convertFlutterSurfaceToImage',
-      null,
     );
     _isSurfaceRendered = true;
 
     addTearDown(() async {
       assert(_isSurfaceRendered, 'Surface is not an image');
       await integrationTestChannel.invokeMethod<void>(
         'revertFlutterImage',
-        null,
       );
       _isSurfaceRendered = false;
     });

Original file line number	Diff line number	Diff line change
`@@ -500,7 +500,6 @@ class SystemChrome {`
`500`	`500`	`if (callback != null) {`
`501`	`501`	`await SystemChannels.platform.invokeMethod<void>(`
`502`	`502`	`'SystemChrome.setSystemUIChangeListener',`
`503`		`- null,`
`504`	`503`	`);`
`505`	`504`	`}`
`506`	`505`	`}`
`@@ -517,7 +516,6 @@ class SystemChrome {`
`517`	`516`	`static Future<void> restoreSystemUIOverlays() async {`
`518`	`517`	`await SystemChannels.platform.invokeMethod<void>(`
`519`	`518`	`'SystemChrome.restoreSystemUIOverlays',`
`520`		`- null,`
`521`	`519`	`);`
`522`	`520`	`}`
`523`	`521`
Original file line number	Diff line number	Diff line change
`@@ -5268,7 +5268,7 @@ class _NamedRestorationInformation extends _RestorationInformation {`
`5268`	`5268`
`5269`	`5269`	`@override`
`5270`	`5270`	`Route<dynamic> createRoute(NavigatorState navigator) {`
`5271`		`- final Route<dynamic> route = navigator._routeNamed<dynamic>(name, arguments: arguments, allowNull: false)!;`
	`5271`	`+ final Route<dynamic> route = navigator._routeNamed<dynamic>(name, arguments: arguments)!;`
`5272`	`5272`	`assert(route != null);`
`5273`	`5273`	`return route;`
`5274`	`5274`	`}`