Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional payload in ConnectionAck #59

Closed
Amareis opened this issue Nov 6, 2020 · 3 comments · Fixed by #60
Closed

Optional payload in ConnectionAck #59

Amareis opened this issue Nov 6, 2020 · 3 comments · Fixed by #60
Labels
enhancement New feature or request good first issue Issue tackles a good aspect released Has been released and published

Comments

@Amareis
Copy link

Amareis commented Nov 6, 2020

Story

As a server developer I want to pass some connection context to client (for example - current session registration step).

So that client can get it without additional requests.

Acceptance criteria

  • server is able to pass payload in ConnectionAck message (return object in onConnect instead of true?).
  • client is able to handle it properly (pass it in on connected event?).

In subscription-transport-ws it's mentioned in docs, but not implemented in code.

@enisdenjo
Copy link
Owner

enisdenjo commented Nov 6, 2020

Hey, thanks for opening this issue - it makes a lot of sense to support something like this!

I'll see what I can do. 👍

@Amareis
Copy link
Author

Amareis commented Nov 7, 2020

Oh, big thanks for such fast fix! We really will transfer from subscriptions-transport-ws on next week.

@enisdenjo
Copy link
Owner

🎉 This issue has been resolved in version 1.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@enisdenjo enisdenjo added the released Has been released and published label Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Issue tackles a good aspect released Has been released and published
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants