Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering issues with Iris, More Culling and potentially other mods #19

Open
SplendidAlakey opened this issue Jul 28, 2022 · 7 comments

Comments

@SplendidAlakey
Copy link

SplendidAlakey commented Jul 28, 2022

MC 1.19.1
Fabric API 0.58.5
Iris 1.2.6
Sodium 0.4.2
Indium 1.0.6
Show Me Your Skin! 1.2.1

To reproduce:

  1. Equip any armor
  2. Open the SMYS' GUI and set armor visibility to anything that's not 0% or 100%
  3. Rendering on the GUI itself is completely broken; rendering in game is ok-ish, but you can see slight issues, e.g. you can see the outlines of the armor while your shadow is in the background (and maybe under some other conditions too, I didn't test it extensively)

Just having Iris installed is enough to reproduce the issue, you don't have to use any actual shaders. Works without Iris, but with Sodium still installed.

Logs: https://gist.github.com/SplendidAlakey/0f539d5c287fd33cd351f039493426b0

Screenshots:

2022-07-28_14 02 32

2022-07-28_14 02 36

@enjarai
Copy link
Owner

enjarai commented Jul 28, 2022

I've used this mod with iris myself for a while, and never really encountered issues. The logs mention you run a GTX 980, which should be similar enough to my GTX 1060 that I doubt this is a gpu-specific issue.

MC is generally very quirky with transparency and I'm quite new to rendering, so it's likely I made a mistake somewhere, and I wouldnt know where to even begin debugging that. 😅

Assuming its not my janky code at fault, the only other things I can think of is your graphics drivers being out of date, or some other mod conflicting for some reason. So maybe try updating your drivers or removing other mods until it works.

Does setting your graphics to fabulous make any difference?

@SplendidAlakey
Copy link
Author

My drivers aren't the latest, because I generally don't need it, as I never play any new games. But I'll try updating it.

I tested the issue only with Sodium, Indium, Iris, Fabric API and your mod. Logs mention 56 mods because each Fabric API module counts as a mod.

Fabulous setting does not exist with Sodium, which is a hard requirement for Iris. Even if you bring up vanilla menu and change it there, it simply resets back to Fancy.

@enjarai
Copy link
Owner

enjarai commented Jul 28, 2022

Ah okay, I really don't know then. I'll try to look into it, but I can't make any promises.

@SplendidAlakey
Copy link
Author

Updated my GPU drivers, but sadly that didn't help.

No worries if you can't fix it, the mod is still usable.

Are you able to reproduce this issue on your end? Because if not, that could indicate Iris issues specifically with my hardware.

@enjarai
Copy link
Owner

enjarai commented Jul 31, 2022

Actually looking closely, I can confirm the same issue on my side. I usually never notice it, since I have my opacity set relatively high.

It's still unlikely to be fixed by me any time soon though, due to the reasons stated before. But if you can find someone able and willing to fix it, I'd be more than happy to accept a PR.

@enjarai enjarai changed the title Rendering issues with Iris Rendering issues with Iris, More Culling and potentially other mods Jul 3, 2023
@enjarai
Copy link
Owner

enjarai commented Jul 3, 2023

Renaming this issue to track similar problems caused by other mods as well.

@FxMorin
Copy link

FxMorin commented May 24, 2024

I'm only kinda late.
With MoreCulling, you can fix the issue by disabling the entity culling option. Which is automatically disabled when you use sodium anyways.
There's a good chance I drop support for it at some point soon-ish...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants