Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Java String Templates; either (probably) with simple String Concatenation [or real Template Engine, but... why?] #698

Open
vorburger opened this issue May 19, 2024 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@vorburger
Copy link
Member

See https://bugs.openjdk.org/browse/JDK-8329949

Noticed from google/google-java-format@fdf4b29

@vorburger
Copy link
Member Author

@vorburger vorburger added the help wanted Extra attention is needed label Oct 6, 2024
@vorburger
Copy link
Member Author

This will also unblock upgrading google-java-formatter from 1.21.0 to 1.24.0; that's currently blocked due to this failure:

java/dev/enola/web/ThingUI.java:85:50: error: did not generate token "."
            sb.append(STR."<td class=\"label\">\{link(nameValue.getKey())}</td>");
                                                 ^
tools/hello/src/main/java/dev/enola/common/hello/Hello.java:30:30: error: did not generate token "."
        return STR."hello, \{planet}";
                             ^
tools/hello/src/main/java/dev/enola/common/hello/Library.java:24:30: error: did not generate token "."
        return STR."hello, \{planet}";
                             ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant