You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
s3fs is a convenient package to interact with s3 (feels like coding against normal file system), but since s3f3 relies on the async aiobotocore package some issues arised:
due to very strict dependencies in both boto3 and aiobotocore, the pip solver was not able to solve this unless defining boto3 as an additional install from s3fs (see daeb285 for fix)
aiobotocore/s3fs keep in an recursive loop copy-pasting the files in the pytest-context leasing to an ever increasing file size when running the tests. Has been solved by relying on boto3 instead for the download, see 28a5e42
s3fs is a convenient package to interact with s3 (feels like coding against normal file system), but since s3f3 relies on the async aiobotocore package some issues arised:
raw_headers
which are not according to specs in the moto-library used in the testing (see aiobotocore AttributeError - missing raw_headers getmoto/moto#3259 for description and 802b9f5 for the fix)Hence, these issues have been handled in https://github.com/enram/vptstools/tree/SVH-country-filter, but I'm not sure if the convenience of s3fs is worthwhile having it as a dependency. It might be that excluding s3fs would make things easier to maintain.
The text was updated successfully, but these errors were encountered: