Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to new resolver sometimes erroneously showing when wallet isn't connected #1525

Open
cthulu-dot-eth opened this issue Jun 12, 2022 · 0 comments

Comments

@cthulu-dot-eth
Copy link

cthulu-dot-eth commented Jun 12, 2022

Describe the bug
When a user searches for their ENS name without their wallet being connected, the Manager UI sometimes erroneously prompts the user to migrate the ENS name to the new resolver, even when it was never set to the old resolver.

To Reproduce

  1. Go to https://app.ens.domains
  2. Connect Metamask
  3. Search for your ENS name
  4. Close the tab
  5. Clear the browser cache
  6. Go back to https://app.ens.domains
  7. This time Metamask is connected, but the ENS manager isn't
  8. Search for the ENS name again

This time it should say that you can't Add or Edit records until you migrate to the new resolver.

Screenshots
resolver

People then try to set the resolver again, which the UI allows, but it never creates an actual transaction so it pends forever:
Screenshot 2022-06-13 073537

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser: Brave
  • Version: 1.39.122
  • Wallet: Metamask
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant