Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

Change testrpc dependency for ganache-cli. #370

Open
jurajpiar opened this issue Dec 13, 2020 · 2 comments
Open

Change testrpc dependency for ganache-cli. #370

jurajpiar opened this issue Dec 13, 2020 · 2 comments

Comments

@jurajpiar
Copy link

Currently this uses an old testrpc dependency, which should be changed to ganache-cli.
One of the issues this would resolve is related to the testrpc package having webpack as a direct dependency, which causes problems in projects that require webpack of higher version. Ganache-cli solves this by putting its webpack dep. in dev dependencies.

I've ran the tests with ganach-cli without failing, so if you like I can create a PR.

@sambacha
Copy link

sambacha commented Apr 8, 2021

an example of how this is creating weird dependencies:

hardhat-template@0.0.1
└─┬ ethereum-waffle@3.3.0
  └─┬ @ethereum-waffle/provider@3.3.2
    └─┬ @ethereum-waffle/ens@3.2.4
      └─┬ @ensdomains/ens@0.4.5
        └── testrpc@0.0.1

@chancehudson
Copy link

This is a very simple fix that is causing real issues in downstream projects. Could someone review #334? The problem is literally solved.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants