Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseXYPlot creates invalid screen points #272

Closed
cfarrow opened this issue May 14, 2015 · 0 comments · Fixed by #802
Closed

BaseXYPlot creates invalid screen points #272

cfarrow opened this issue May 14, 2015 · 0 comments · Fixed by #802

Comments

@cfarrow
Copy link
Contributor

cfarrow commented May 14, 2015

It is possible to get invalid screen points from a BaseXYPlot.map_screen.

Starting here:
If data_array is 1-dimensional and one of the points is out of bounds, then the LinearMapper being used to map the screen point (here) will return an array. Meanwhile, for the in-bounds point a scalar will be returned (here). Then the BaseXYPlot packs the array and scalar into a single object array which is not the right thing to do.

I think the right solution is to have the BaseXYPlot handle this corner case, but the LinearMapper might be to blame since in both places the proper behavior is not documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant