Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip install from PyPI fails if NumPy not already installed #372

Closed
mdickinson opened this issue Aug 4, 2017 · 4 comments · Fixed by #730
Closed

pip install from PyPI fails if NumPy not already installed #372

mdickinson opened this issue Aug 4, 2017 · 4 comments · Fixed by #730

Comments

@mdickinson
Copy link
Member

Chaco depends on NumPy, but doesn't declare that dependency in its setup.py.

@corranwebster
Copy link
Contributor

But Chaco does depend on Enable, which does declare a dependency on Numpy, so you shouldn't every be in a situation where you don't have Numpy?

@rkern
Copy link
Member

rkern commented Aug 7, 2017

Note that the setup.py uses numpy, so adding it there won't accomplish anything except alleviating some OCD. If the goal is to get pip to work, you'll need a sidecar requirements.txt listing numpy.

@mdickinson
Copy link
Member Author

If the goal is to get pip to work

Sorry, yes, that was indeed the goal. Right now, pip install chaco to install from PyPI fails if NumPy isn't already installed. I should retitle this issue.

I'd argue that numpy should be added to the setup.py anyway as a runtime dependency, so that if one day we manage to produce wheels for Chaco then pip will be able to resolve dependencies properly.

@mdickinson mdickinson changed the title setup.py does not declare a dependency on NumPy pip install from PyPI fails if NumPy not already installed Aug 7, 2017
@mdickinson
Copy link
Member Author

But Chaco does depend on Enable, which does declare a dependency on Numpy, so you shouldn't every be in a situation where you don't have Numpy?

Hmm, true. I guess the need to add NumPy to the runtime requirements really is at OCD level, then. :-)

And at that level, I'd say that the general rule is that any package that Chaco imports directly from should be in the requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants