Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should CompiledPath and font_metrics_provider be added to enable.api #772

Closed
rahulporuri opened this issue Apr 6, 2021 · 5 comments · Fixed by #788
Closed

Should CompiledPath and font_metrics_provider be added to enable.api #772

rahulporuri opened this issue Apr 6, 2021 · 5 comments · Fixed by #788

Comments

@rahulporuri
Copy link
Contributor

rahulporuri commented Apr 6, 2021

CompiledPath and font_metrics_provider aren't available via enable.api at the moment and I don't see a good reason why it shouldn't be. There are a few places in chaco which do from enable.compiled_path import CompiledPath and from enable.font_metrics_provider import font_metrics_provider.

Ref https://github.com/enthought/chaco/search?q=%22enable.compiled_path%22 and https://github.com/enthought/chaco/search?q=font_metrics_provider

@rahulporuri rahulporuri changed the title Add CompiledPath to enable.api Should CompiledPath and font_metrics_provider be added to enable.api Apr 6, 2021
@rahulporuri
Copy link
Contributor Author

@jwiggins do you think it'll be a problem if we force toolkit selection if anyone imports anything from enable.api?

@jwiggins
Copy link
Member

jwiggins commented Apr 7, 2021

enable.colors, which is imported from enable.api, is already forcing toolkit selection at import time.

@jwiggins
Copy link
Member

jwiggins commented Apr 7, 2021

As long as that was done deliberately (if it's even possible to find out now), then I think it's OK to add CompiledPath and font_metrics_provider

@rahulporuri
Copy link
Contributor Author

As long as that was done deliberately (if it's even possible to find out now),

Sadly, this goes back all the way b3420c3 so we have no way of knowing if it was deliberate or not

@jwiggins
Copy link
Member

jwiggins commented Apr 7, 2021

Well in that case it's de facto OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants