-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests broken with ipykernel 4.7.0 #107
Comments
Steps to reproduce with current master: using a Python environment that has
Test output
|
ipykernel is now at 4.7.0 in EDM, so our CI is failing on master. This is critical to fix. |
@mdickinson seems related to ipython/ipykernel#319 |
Also possibly related to jupyter-server/kernel_gateway#131 |
Attempting to pick this up again. I'm currently investigating this single test failure, and I'll go on from there.
|
Digging into this: we're hitting this in the
The previous implementation of this method, from ipykernel 4.6.1, looked like this:
Here Possible workarounds: (1) make sure we actually start the kernel in the test. This would better match the behaviour of the app. (2) monkey-patch the |
I have all the test passing by adding the following in the
@mdickinson how do you feel with this? |
If it gets all the tests passing, let's do it. I'm reasonably convinced from previous investigations that the failures don't represent a real issue with the actual app. |
@mdickinson happy, happy, test suite passes nicely now |
The recent release of ipykernel 4.7.0 appears to break Envisage.
Sample failures, from https://travis-ci.org/enthought/envisage/jobs/312429428 (the later failures are probably consequences of the first one):
The text was updated successfully, but these errors were encountered: