Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recursion support for observe? #1339

Closed
kitchoi opened this issue Nov 6, 2020 · 1 comment
Closed

Recursion support for observe? #1339

kitchoi opened this issue Nov 6, 2020 · 1 comment
Labels
component: core Issues related to the core library resolution: rejected The proposed change will not be implemented topic: traits listener rework Issues related to reworking listener infrastructure; see also EEP2, EEP3 type: discussion type: enhancement

Comments

@kitchoi
Copy link
Contributor

kitchoi commented Nov 6, 2020

Currently observe does not support the recursive pattern * that is supported in on_trait_change.

This issue is open for discussion whether there are enough use cases to extend the recursion support to observe.

I found one potential use case, that would be for solving enthought/apptools#194 where the notification machinery is reacting to changes to any traits on a subclass and the structure of the traits is not known by the base class.

An experimental implementation for the support can be found here: #1242
@mdickinson
Copy link
Member

Closing; we don't have good enough use-cases for now, and the recursion adds sufficient complexity that we don't want to do it without a really good reason.

@mdickinson mdickinson added type: enhancement component: core Issues related to the core library topic: traits listener rework Issues related to reworking listener infrastructure; see also EEP2, EEP3 resolution: rejected The proposed change will not be implemented labels Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: core Issues related to the core library resolution: rejected The proposed change will not be implemented topic: traits listener rework Issues related to reworking listener infrastructure; see also EEP2, EEP3 type: discussion type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mdickinson @kitchoi