-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bad TraitListEvent from ListStrEditor and TabularEditor #791
Comments
Note: the equivalent |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
ListStrEditor
andTabularEditor
createTraitListEvents
withremoved
andadded
reversed. See:traitsui/traitsui/qt4/list_str_editor.py
Line 335 in 3e2ce86
and:
traitsui/traitsui/qt4/tabular_editor.py
Line 449 in 3e2ce86
The signature of the
TraitListEvent
initializer isTo avoid similar errors in the future, I recommend passing these arguments by keyword instead of by position. I think we should also make them keyword-only in Traits.
I'd mark this with "Good first issue", except that I think writing the tests may be nontrivial.
The text was updated successfully, but these errors were encountered: