Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding a logger to the context object #56

Open
ceejbot opened this issue Nov 20, 2020 · 1 comment
Open

Consider adding a logger to the context object #56

ceejbot opened this issue Nov 20, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@ceejbot
Copy link
Contributor

ceejbot commented Nov 20, 2020

Specifically so the logger can have a request id associated with it automatically. This would enhance out-of-the-box logging with a pattern we'd like to support.

@ceejbot ceejbot added the enhancement New feature or request label Nov 20, 2020
@chrisdickinson
Copy link
Contributor

Hm, I still dislike that this would lead to baton passing / encourage improper use of bole. We might restate this issue in terms of end goals: the request id should end up in log lines. It might be possible to do this without baton-passing by leaning on honeycomb's use of async-hooks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants