Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate circle-ci job to a github action #90

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Conversation

cooldracula
Copy link
Contributor

This PR removes the current circleci workflow and replaces it with an analogous github action. An example of the gh job in action can be found in cooldracula/programs.

This PR would resolve resolve one of the remaining tasks in devops-infrastructure PR #59

Copy link
Contributor

@ameba23 ameba23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Great. only thing i am unsure about is what rust version ubuntu-latest comes with. is that currently ubuntu 24? I think the current stable version of rust is 1.8.

We should really add tests to this script - but thats another PR.

@cooldracula
Copy link
Contributor Author

💯 Great. only thing i am unsure about is what rust version ubuntu-latest comes with. is that currently ubuntu 24? I think the current stable version of rust is 1.8.

Ubuntu latest is Ubuntu 22.04 and it comes installed with rust 1.8. You can see all the rust tools it comes with here:
https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md#rust-tools.

Copy link
Contributor

@HCastano HCastano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn, the CI is pretty lean in this repo 😅

@HCastano HCastano merged commit f14d88b into master Aug 9, 2024
2 checks passed
@HCastano HCastano deleted the zach/migrate-circle-ci branch August 9, 2024 15:10
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants