Skip to content
This repository has been archived by the owner on Jan 16, 2023. It is now read-only.

Updater code affects timeout globally #125

Open
mikejolley opened this issue Feb 24, 2016 · 1 comment
Open

Updater code affects timeout globally #125

mikejolley opened this issue Feb 24, 2016 · 1 comment

Comments

@mikejolley
Copy link

See this line: https://github.com/envato/envato-wordpress-toolkit/blob/b244c5a4b86f9950ec52610dfdbff2cc0c3a4ab1/includes/class-github-updater.php#L74

Code reduces the default timeout from 5 to 2, which can cause issues with slower requests and other plugins. There is no valid reason to reduce the timeout so this line should probably be removed.

@kraftbj
Copy link

kraftbj commented Feb 24, 2016

In case the line needs to remain, suggesting this upstream to be more surgical: radishconcepts/WordPress-GitHub-Plugin-Updater#79

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants