Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CacheFilter: Upgrade GET requests whose upgrade headers are not removed should bypass the cache #11734

Closed
yosrym93 opened this issue Jun 24, 2020 · 2 comments
Closed

CacheFilter: Upgrade GET requests whose upgrade headers are not removed should bypass the cache #11734

yosrym93 opened this issue Jun 24, 2020 · 2 comments
Labels
area/cache help wanted Needs help!

Comments

@yosrym93
Copy link
Contributor

yosrym93 commented Jun 24, 2020 •
edited
Loading

The CacheFilter (#7198) should bypass cache for any upgrade GET requests that Envoy does not strip the upgrade header for before proxying it upstream. The reason for this is that if the upgrade header is forwarded upstream, then this means that this is a request that wants the origin (as opposed to the proxy) to change the communication protocol. Responses to these requests should not be cached.
@stale
Copy link

stale bot commented Jul 25, 2020

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label Jul 25, 2020
@alyssawilk alyssawilk added the help wanted Needs help! label Jul 27, 2020
@stale stale bot removed the stale stalebot believes this issue/PR has not been touched recently label Jul 27, 2020
@yosrym93 yosrym93 changed the title CacheFilter: Websocket protocol requests should skip the cache CacheFilter: Upgrade GET requests whose upgrade headers are not removed should bypass the cache Aug 27, 2020
@yosrym93
Copy link
Contributor Author

We don't have enough information for why this is needed at the moment. I'll close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/cache help wanted Needs help!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@asraa @alyssawilk @yosrym93