Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverage: need to see critical/assert logs in coverage builds #11860

Closed
mattklein123 opened this issue Jul 1, 2020 · 0 comments · Fixed by #11861
Closed

coverage: need to see critical/assert logs in coverage builds #11860

mattklein123 opened this issue Jul 1, 2020 · 0 comments · Fixed by #11861

Comments

@mattklein123
Copy link
Member

See discussion in #11784.

Right now if we hit an assert it's not clear because we only print the backtrace, due to:

envoy/.bazelrc

Line 132 in 3cc670d

coverage:test-coverage --test_arg="--log-path /dev/null"

We need to figure out a way to see more logs in coverage when things fail. cc @alyssawilk @antoniovicente @jmarantz @lizan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant