Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: Is decodeData called with end_stream set to true guaranteed to be called even when there are HTTP trailers in the request? #12196

Closed
hq6 opened this issue Jul 21, 2020 · 3 comments
Closed

Question: Is decodeData called with end_stream set to true guaranteed to be called even when there are HTTP trailers in the request? #12196

hq6 opened this issue Jul 21, 2020 · 3 comments
Labels
question Questions that are neither investigations, bugs, nor enhancements stale stalebot believes this issue/PR has not been touched recently

Comments

@hq6
Copy link
Contributor

hq6 commented Jul 21, 2020

This comment states that "end_stream supplies whether this is the last data frame."

If there are HTTP trailers in the request (in some sense, additional data after the last data frame), is it guaranteed that decodeData will be called at least once with end_stream set to true?
@hq6 hq6 changed the title Question: Is decodeData called with end_stream set to true called even when there are HTTP trailers in the request? Question: Is decodeData called with end_stream set to true guaranteed to be called even when there are HTTP trailers in the request? Jul 21, 2020
@mattklein123 mattklein123 added the question Questions that are neither investigations, bugs, nor enhancements label Jul 21, 2020
@mattklein123
Copy link
Member

If there are HTTP trailers in the request (in some sense, additional data after the last data frame), is it guaranteed that decodeData will be called at least once with end_stream set to true?

No, end_stream is only true if there are no trailers. Please feel free to PR a comment fix.

@stale
Copy link

stale bot commented Aug 23, 2020

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label Aug 23, 2020
@stale
Copy link

stale bot commented Sep 2, 2020

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted". Thank you for your contributions.

@stale stale bot closed this as completed Sep 2, 2020
@wangfakang wangfakang mentioned this issue Jan 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Questions that are neither investigations, bugs, nor enhancements stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hq6 @mattklein123