Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run docker CI job in pre-submit and #12297

Closed
lizan opened this issue Jul 26, 2020 · 3 comments
Closed

Run docker CI job in pre-submit and #12297

lizan opened this issue Jul 26, 2020 · 3 comments
Labels
stale stalebot believes this issue/PR has not been touched recently tech debt

Comments

@lizan
Copy link
Member

lizan commented Jul 26, 2020 •
edited
Loading

Currently the docker CI job is only run in post-submit. It is desired to have it also run in pre-submit without push image to dockerhub. It can save the image as artifact with docker save. Running ci/verify_examples.sh there will be even better.
@lizan
Copy link
Member Author

lizan commented Jul 26, 2020

@phlax

@stale
Copy link

stale bot commented Aug 29, 2020

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label Aug 29, 2020
@lizan
Copy link
Member Author

lizan commented Aug 31, 2020

Fixed in #12662

@lizan lizan closed this as completed Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale stalebot believes this issue/PR has not been touched recently tech debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lizan @alyssawilk