Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extensions/filters/http/oath2 coverage #13033

Closed
asraa opened this issue Sep 9, 2020 · 0 comments · Fixed by #14479
Closed

extensions/filters/http/oath2 coverage #13033

asraa opened this issue Sep 9, 2020 · 0 comments · Fixed by #14479
Assignees
Labels
no stalebot Disables stalebot from closing an issue tech debt

Comments

@asraa
Copy link
Contributor

asraa commented Sep 9, 2020

Hello,
The Envoy project has been collecting per-extension coverage. You have been tagged with this issue as you are a co-owner of an extension, source/filters/http/oath2, which is below the 96.6 percent coverage mark.
Could you please take a look at coverage results (https://storage.googleapis.com/envoy-postsubmit/master/coverage/index.html) and add more tests when you get a chance? Once this is done you should be able to remove your extension from the exempt extensions in test/per_file_coverage.sh

Note: It is just below the coverage line at 96.5, filing this just for tech debt removal of removing the line when code coverage exceeds 96.6.

Thanks!

@asraa asraa added tech debt no stalebot Disables stalebot from closing an issue labels Sep 9, 2020
@alyssawilk alyssawilk reopened this Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no stalebot Disables stalebot from closing an issue tech debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants