-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How about add HeaderMatch for http local ratelimit? #14161
Comments
I think it's valuable. Sometimes we do need to do some extra match to decide if we need to make a flow control. |
The goal here should be to use the new generic matching support that @snowp is working on. I think we are making good progress on that. |
@mattklein123 I've been looking forward to generic matching support for a long time, where can I get the latest progress? |
@snowp should be able to summarize and/or point you to current status. I think we are pretty close to having something we can start to build on in different filters. |
This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions. |
@mattklein123 with #14462 now merged, how much closer are we to be able to accomplish the request in this issue? Could you please point to reference syntax on how to do this in the yaml config, if it is different than the one ydh926 listed? |
With what's merged today you should be able to trigger a skip filter action based on matching on the request headers, similar to how this test works: envoy/test/integration/integration_test.cc Lines 371 to 393 in e53227e
Happy to answer any questions you might have |
This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions. |
This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions. |
Title: HeaderMatch for http local ratelimit
Description:
For example, limit a special user's request, we may need HeaderMatch in limit config , like this:
The text was updated successfully, but these errors were encountered: