Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to enforce required coverage over certain lines? #14766

Closed
asraa opened this issue Jan 20, 2021 · 2 comments
Closed

Possible to enforce required coverage over certain lines? #14766

asraa opened this issue Jan 20, 2021 · 2 comments
Labels
area/security stale stalebot believes this issue/PR has not been touched recently

Comments

@asraa
Copy link
Contributor

asraa commented Jan 20, 2021

Description
To validate that ENVOY_BUG conditions have code coverage, is it possible to issue warnings or a make a required check that a condition is tested for success and failure by leveraging the existing coverage report?

Motivation:

  • Encourages failure condition testing, especially since these are fatal in debug mode
  • Ensures that Envoy can continue safely even if hitting an ENVOY_BUG condition in release mode.

Difficulties:

  • With a normal coverage report, it's opaque whether the ENVOY_BUG condition passes or fails.

See
#14575

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Feb 22, 2021
@github-actions
Copy link

github-actions bot commented Mar 2, 2021

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

@github-actions github-actions bot closed this as completed Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/security stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

No branches or pull requests

1 participant