~GrpcMuxWatchImpl() uses watches_.remove(this) which traverses the list.

[efimki]

Title: ~GrpcMuxWatchImpl() uses watches_.remove(this) which traverses the list.

Description:

~GrpcMuxWatchImpl() uses std::list::remove() to remove itself from watches_ list.
This traverses the list and takes O(N) for each destruction.
We could speed things up to O(1) if GrpcMuxWatchImpl would keep a list iterator for itself and used std::list::erase() instead.

[stevenzzzz]

cc @htuch @chaoqin-li1123 @stevenzzzz

[stevenzzzz]

let's do similar trick as is done in #11751

[stevenzzzz]

cc @htuch

[stevenzzzz]

/cc @htuch

[chaoqin-li1123]

Yeah, I think we can store the list iterator and use it for constant time removal.

[htuch]

Sure, makes sense.

[mk46]

I am taking this. PTAL to linked PR.