Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate network DNS context definition and DNS filter one #17335

Closed
Shikugawa opened this issue Jul 14, 2021 · 7 comments
Closed

Migrate network DNS context definition and DNS filter one #17335

Shikugawa opened this issue Jul 14, 2021 · 7 comments
Labels
api area/dns design proposal Needs design doc/proposal before implementation enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently

Comments

@Shikugawa
Copy link
Member

Shikugawa commented Jul 14, 2021

Record and Query definitions in DNS Filter (e.g. Envoy::Extensions::UdpFilters::DnsFilter::DnsQueryRecord) overlap with definitions in Network namespace. There are many overlaps with definitions in the Network namespace, so there is a possibility to integrate them. This refactor is useful for supporting SRV record lookups in c-ares layer, since the SRV record structure is already defined in DnsFilter.

@Shikugawa Shikugawa added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Jul 14, 2021
@snowp snowp added api design proposal Needs design doc/proposal before implementation and removed triage Issue requires triage labels Jul 16, 2021
@snowp
Copy link
Contributor

snowp commented Jul 16, 2021

@envoyproxy/api-shepherds for comment

@Shikugawa
Copy link
Member Author

I think we don't need any api change on this refactor.

@htuch
Copy link
Member

htuch commented Jul 19, 2021

CC @yanjunxiang-google who is working on #14310. This might be relevant when doing code level refactoring.

@yanjunxiang-google
Copy link
Contributor

HI @Shikugawa,
As Harvey @htuch mentioned, I am working on $14310. The goal is to refactor Envoy DNS resolution and put it as an extension, so Envoy can link in different DNS libraries(c-ares, Apple, et. al) based on requirements.

I will put you as reviewer once I have the PR ready.

thanks,
Yanjun

@Shikugawa
Copy link
Member Author

HI @Shikugawa,
As Harvey @htuch mentioned, I am working on $14310. The goal is to refactor Envoy DNS resolution and put it as an extension, so Envoy can link in different DNS libraries(c-ares, Apple, et. al) based on requirements.

I will put you as reviewer once I have the PR ready.

thanks,
Yanjun

Great. Thanks!

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Aug 19, 2021
@github-actions
Copy link

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api area/dns design proposal Needs design doc/proposal before implementation enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

No branches or pull requests

4 participants