Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports setting the :scheme header of upstream requests based on upstream crypto #30134

Closed
johnlanni opened this issue Oct 12, 2023 · 4 comments
Labels
enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently

Comments

@johnlanni
Copy link
Contributor

Title: Supports setting the scheme header of upstream requests based on upstream encryption

Description:

My scenario is that Envoy receives gRPCs(encrypted) requests and proxies gRPC (not encrypted) request to a .NET service. The .NET gRPC framework checks the :scheme header, if the request is not encrypted, but the :scheme is https, the request will fail.

I solved the problem by setting the HCM option scheme_header_transformation to http, but this option has a side effect of setting the XFP header to http, which makes it impossible to determine the Envoy downstream protocol through the XFP header.

As @alyssawilk commented here, we may need to extend the cluster configuration options to set the scheme based on upstream crypto instead of defaulting to XFP.

@johnlanni johnlanni added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Oct 12, 2023
@johnlanni
Copy link
Contributor Author

I'm interested in implementing this feature if you guys think it's needed.
cc @alyssawilk

@alyssawilk alyssawilk removed the triage Issue requires triage label Oct 12, 2023
@alyssawilk
Copy link
Contributor

I don't think it's needed but I think it's completely fine to add. cc @yanavlasov because it's sorta header sanitization

Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Nov 11, 2023
Copy link

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

No branches or pull requests

2 participants